Android custom Call parameters are not passed to Twilio about react-native-twilio-programmable-voice HOT 6 CLOSED

I work on the Programmable Voice SDKs and can provide some guidance on this issue.

Passing custom parameters from the Android or iOS SDK to the server application is supported. However, propagating these custom parameters into the Twilio helper library to another client from your server code is not (this is a feature that has been requested and is in our backlog). If your server application requires additional context you are welcome to add custom parameters.

I would recommend either removing the validation and passing the params "as-is" in this method or using a flag to opt-out of this validation when needed. https://github.com/hoxfon/react-native-twilio-programmable-voice/blob/master/android/src/main/java/com/hoxfon/react/RNTwilioVoice/TwilioVoiceModule.java#L621-L650

from react-native-twilio-programmable-voice.

I also experienced this issue. And made an pull request based on @idelgado 's suggestion.

#94

from react-native-twilio-programmable-voice.

I also experienced this issue. This library only propagates to Twilio certain params (don't remember which atm). The issue here is how 'correct' is for twilio the use of custom parameters. If twilio says it's okay, this library should propagate all the custom parameters to the twilio android sdk (Don't know how this issue affects iOS)

I'd happily open a PR in that case :D

from react-native-twilio-programmable-voice.

This older article flatly states the mobile client cannot pass custom params, but this twilio API doc instructs you how to do so on android.

I believe it is correct behavior in the sense that Twilio has guides encouraging it and supports it in their other APIs like the Web javascript client

from react-native-twilio-programmable-voice.

Thanks @idelgado to jump in!
Can you confirm that my understanding of your explanation is correct:

Considering the following SDK method call:

Voice.call(getReactApplicationContext(), accessToken, twiMLParams, callListener);

Could twiMLParams be a Map containing any arbitrary number of strings?
If so we could iterate over the Javascript object passed and convert it into a Java Map - which is strongly typed - omitting any key containing non string values.

from react-native-twilio-programmable-voice.

This has been resolved in #94, closing this issue

from react-native-twilio-programmable-voice.