Giter VIP home page Giter VIP logo

Comments (13)

fniephaus avatar fniephaus commented on June 19, 2024 1

@sebastianconcept smalltalkCI always has compatibility packages for Pharo, see SmalltalkCI-Pharo-Core.package which, for example, includes SmalltalkCIPharo11. They inherit from each other, so adding an override via SmalltalkCIPharo11>>#saveImage might do the trick.

from smalltalkci.

Bajger avatar Bajger commented on June 19, 2024

Confirming this: Both P11, P12 are affected. https://github.com/exercism/pharo-smalltalk/actions/runs/7906008750?pr=609

from smalltalkci.

fniephaus avatar fniephaus commented on June 19, 2024

What kind of object is it returning? For Pharo, smalltalkCI simply calls:

from smalltalkci.

Bajger avatar Bajger commented on June 19, 2024

aSnapshotOperation instance is being returned now...
obrazek

from smalltalkci.

fniephaus avatar fniephaus commented on June 19, 2024

Cool, so P11 and P12 again broke public API used by smalltalkCI. We need need a new saveImage impl for them in a compatibility package. Anyone wants to open a PR for this?

from smalltalkci.

sebastianconcept avatar sebastianconcept commented on June 19, 2024

@fniephaus sounds good like this? #632

from smalltalkci.

Bajger avatar Bajger commented on June 19, 2024

Do you know, SmalltalkCIPharo>>#saveImage return boolean originally stands for (meaning)?

from smalltalkci.

labordep avatar labordep commented on June 19, 2024

Hi, I have errors since last night in all of my projects (on Windows, Linux and Mac) during CI:

image

Do you think this is related to this issue?

from smalltalkci.

sebastianconcept avatar sebastianconcept commented on June 19, 2024

@labordep yes, I can confirm you that's the same I've saw in mine.
I've removed Pharo 11 from my CI until this issue is resolved.

from smalltalkci.

labordep avatar labordep commented on June 19, 2024

Thanks @sebastianconcept,
I have this error on Pharo12 CI too ><

from smalltalkci.

labordep avatar labordep commented on June 19, 2024

For Pharo 12:

NonBooleanReceiver: proceed for truth.
SnapshotOperation(ProtoObject)>>mustBeBooleanIn:
SnapshotOperation(ProtoObject)>>mustBeBoolean
SmalltalkCI class>>saveAndQuitImage
UndefinedObject>>DoIt
OCReceiverDoItSemanticScope(OCDoItSemanticScope)>>evaluateDoIt:
OpalCompiler>>evaluate
OpalCompiler>>evaluate:
[
	result := Smalltalk compiler evaluate: aStream.
	self hasSessionChanged
		ifFalse: [
			self stdout
				print: result;
				lf ] ] in EvaluateCommandLineHandler>>evaluate: in Block: [...
FullBlockClosure(BlockClosure)>>on:do:
EvaluateCommandLineHandler>>evaluate:
EvaluateCommandLineHandler>>evaluateArguments
EvaluateCommandLineHandler>>activate
EvaluateCommandLineHandler class(CommandLineHandler class)>>activateWith:
[ aCommandLinehandler activateWith: commandLine ] in PharoCommandLineHandler(BasicCommandLineHandler)>>activateSubCommand: in Block: [ aCommandLinehandler activateWith: commandLine ]
FullBlockClosure(BlockClosure)>>on:do:
PharoCommandLineHandler(BasicCommandLineHandler)>>activateSubCommand:
PharoCommandLineHandler(BasicCommandLineHandler)>>handleSubcommand
PharoCommandLineHandler(BasicCommandLineHandler)>>handleArgument:
[ self handleArgument: self firstArgument ] in [ [ self handleArgument: self firstArgument ]
		on: Exit
		do: [ :exit |
			"If the command line is protected by password, we just exit the image because in non-headless mode the handleExit will let the image open. If the password protection is enabled, it is to avoid to let the access to the image."
			self class commandLinePasswordManager hasPasswordSet
				ifTrue: [ Smalltalk snapshot: false andQuit: true ].
			self handleExit: exit ] ] in PharoCommandLineHandler(BasicCommandLineHandler)>>activate in Block: [ self handleArgument: self firstArgument ]
FullBlockClosure(BlockClosure)>>on:do:
[ [ self handleArgument: self firstArgument ]
		on: Exit
		do: [ :exit |
			"If the command line is protected by password, we just exit the image because in non-headless mode the handleExit will let the image open. If the password protection is enabled, it is to avoid to let the access to the image."
			self class commandLinePasswordManager hasPasswordSet
				ifTrue: [ Smalltalk snapshot: false andQuit: true ].
			self handleExit: exit ] ] in PharoCommandLineHandler(BasicCommandLineHandler)>>activate in Block: [ [ self handleArgument: self firstArgument ]...
[self value.
			"IMPORTANT: Do not step over next line of code. See method comments for details"
			Processor terminateRealActive] in FullBlockClosure(BlockClosure)>>newProcess in Block: [self value....
Error with status code 1:
692 run_script /home/runner/.smalltalkCI/helpers.sh

Error: Process completed with exit code 1.

from smalltalkci.

sebastianconcept avatar sebastianconcept commented on June 19, 2024

@fniephaus sounds good, thanks for elaborating. Do we have a PR for it, should I try to help with one?

from smalltalkci.

fniephaus avatar fniephaus commented on June 19, 2024

@noha has created #634. I'll merge it if all goes well.

from smalltalkci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.