Comments (13)
@sebastianconcept smalltalkCI always has compatibility packages for Pharo, see SmalltalkCI-Pharo-Core.package which, for example, includes SmalltalkCIPharo11
. They inherit from each other, so adding an override via SmalltalkCIPharo11>>#saveImage
might do the trick.
from smalltalkci.
Confirming this: Both P11, P12 are affected. https://github.com/exercism/pharo-smalltalk/actions/runs/7906008750?pr=609
from smalltalkci.
What kind of object is it returning? For Pharo, smalltalkCI simply calls:
from smalltalkci.
aSnapshotOperation
instance is being returned now...
from smalltalkci.
Cool, so P11 and P12 again broke public API used by smalltalkCI. We need need a new saveImage
impl for them in a compatibility package. Anyone wants to open a PR for this?
from smalltalkci.
@fniephaus sounds good like this? #632
from smalltalkci.
Do you know, SmalltalkCIPharo>>#saveImage return boolean originally stands for (meaning)?
from smalltalkci.
Hi, I have errors since last night in all of my projects (on Windows, Linux and Mac) during CI:
Do you think this is related to this issue?
from smalltalkci.
@labordep yes, I can confirm you that's the same I've saw in mine.
I've removed Pharo 11 from my CI until this issue is resolved.
from smalltalkci.
Thanks @sebastianconcept,
I have this error on Pharo12 CI too ><
from smalltalkci.
For Pharo 12:
NonBooleanReceiver: proceed for truth.
SnapshotOperation(ProtoObject)>>mustBeBooleanIn:
SnapshotOperation(ProtoObject)>>mustBeBoolean
SmalltalkCI class>>saveAndQuitImage
UndefinedObject>>DoIt
OCReceiverDoItSemanticScope(OCDoItSemanticScope)>>evaluateDoIt:
OpalCompiler>>evaluate
OpalCompiler>>evaluate:
[
result := Smalltalk compiler evaluate: aStream.
self hasSessionChanged
ifFalse: [
self stdout
print: result;
lf ] ] in EvaluateCommandLineHandler>>evaluate: in Block: [...
FullBlockClosure(BlockClosure)>>on:do:
EvaluateCommandLineHandler>>evaluate:
EvaluateCommandLineHandler>>evaluateArguments
EvaluateCommandLineHandler>>activate
EvaluateCommandLineHandler class(CommandLineHandler class)>>activateWith:
[ aCommandLinehandler activateWith: commandLine ] in PharoCommandLineHandler(BasicCommandLineHandler)>>activateSubCommand: in Block: [ aCommandLinehandler activateWith: commandLine ]
FullBlockClosure(BlockClosure)>>on:do:
PharoCommandLineHandler(BasicCommandLineHandler)>>activateSubCommand:
PharoCommandLineHandler(BasicCommandLineHandler)>>handleSubcommand
PharoCommandLineHandler(BasicCommandLineHandler)>>handleArgument:
[ self handleArgument: self firstArgument ] in [ [ self handleArgument: self firstArgument ]
on: Exit
do: [ :exit |
"If the command line is protected by password, we just exit the image because in non-headless mode the handleExit will let the image open. If the password protection is enabled, it is to avoid to let the access to the image."
self class commandLinePasswordManager hasPasswordSet
ifTrue: [ Smalltalk snapshot: false andQuit: true ].
self handleExit: exit ] ] in PharoCommandLineHandler(BasicCommandLineHandler)>>activate in Block: [ self handleArgument: self firstArgument ]
FullBlockClosure(BlockClosure)>>on:do:
[ [ self handleArgument: self firstArgument ]
on: Exit
do: [ :exit |
"If the command line is protected by password, we just exit the image because in non-headless mode the handleExit will let the image open. If the password protection is enabled, it is to avoid to let the access to the image."
self class commandLinePasswordManager hasPasswordSet
ifTrue: [ Smalltalk snapshot: false andQuit: true ].
self handleExit: exit ] ] in PharoCommandLineHandler(BasicCommandLineHandler)>>activate in Block: [ [ self handleArgument: self firstArgument ]...
[self value.
"IMPORTANT: Do not step over next line of code. See method comments for details"
Processor terminateRealActive] in FullBlockClosure(BlockClosure)>>newProcess in Block: [self value....
Error with status code 1:
692 run_script /home/runner/.smalltalkCI/helpers.sh
Error: Process completed with exit code 1.
from smalltalkci.
@fniephaus sounds good, thanks for elaborating. Do we have a PR for it, should I try to help with one?
from smalltalkci.
@noha has created #634. I'll merge it if all goes well.
from smalltalkci.
Related Issues (20)
- Add Rowan v2 support to smalltalkCI HOT 1
- Failing jobs for Pharo32-xx (Linux, MacOs and Windows) HOT 4
- Exit status canβt be used to distinguish between tests not passing and other errors HOT 3
- Update GitHub action HOT 3
- Question: How to use Windows OS with GitLab ? HOT 2
- GemStone github action runs fail on mac-os for 3.7.0 HOT 1
- [Question] How to configure merge request trigger on a GitLab server ? HOT 2
- Cannot execute extensions tag unit tests HOT 5
- Please release upgraded Squeak Trunk images to resolve conflict in update stream HOT 1
- [Bug] Error when load in new image on Windows: curl failed to download get.pharo.org/64/vm110 HOT 8
- `PackageOrganizer>>#listAtCategoryNamed:` deprecated in Pharo 12 HOT 3
- Pharo12-alpha broke Metacello HOT 1
- Metacello broken again for Pharo 12 HOT 4
- Pharo12 builds fail because they removed Time>>millisecondsToRun: HOT 2
- Unable to parse Coveralls build data HOT 11
- Github actions warning: node16 actions are deprecated HOT 1
- [Question] Is it sensible to rely on SmalltalkCI code for an asdf plugin? HOT 5
- Compatibility package for Pharo HOT 1
- FFIUnsupportedUntypedLiteral error in Pharo 12 on MacOS & Windows HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smalltalkci.