Giter VIP home page Giter VIP logo

Comments (8)

maru-sama avatar maru-sama commented on July 17, 2024

Reverting to zbus 3.15 for testing fixes the issue for me.

from ncspot.

hrkfdn avatar hrkfdn commented on July 17, 2024

Thanks for the report. What are you using to see the MPRIS status so I can reproduce it?

Edit: Nevermind, can reproduce it with GNOME.

from ncspot.

maru-sama avatar maru-sama commented on July 17, 2024

Hi, gnome automatically displays controls once media is playing, while i see the controls I do not see the information. Let me try and get a screenshot.

from ncspot.

hrkfdn avatar hrkfdn commented on July 17, 2024

I did some digging and the only difference I could spot so far is how the PropertiesChanged message structure has changed:

Old:

   array [
      dict entry(
         string "Metadata"
         variant             array [
               dict entry(
                  string "mpris:length"
                  variant                      int64 169887000
               )
               dict entry(
                  string "xesam:userRating"
                  variant                      double 0
               )
               dict entry(
                  string "xesam:artist"
                  variant                      array [
                        string "Thing"
                     ]
               )
               dict entry(
                  string "xesam:url"
                  variant                      string "https://open.spotify.com/track/4EPRCsMgi6sKI68VE6iads"
               )
               dict entry(
                  string "xesam:discNumber"
                  variant                      int32 1
               )
               dict entry(
                  string "xesam:title"
                  variant                      string "Past Love"
               )
               dict entry(
                  string "xesam:albumArtist"
                  variant                      array [
                        string "Thing"
                     ]
               )
               dict entry(
                  string "xesam:trackNumber"
                  variant                      int32 1
               )
               dict entry(
                  string "mpris:artUrl"
                  variant                      string "https://i.scdn.co/image/ab67616d0000b2739498ee18bdbdcf28e80ffa05"
               )
               dict entry(
                  string "xesam:album"
                  variant                      string "Past Love"
               )
               dict entry(
                  string "mpris:trackid"
                  variant                      object path "/org/ncspot/spotify/track/4EPRCsMgi6sKI68VE6iads"
               )
            ]
      )
   ]
   array [
   ]

New:

   array [
      dict entry(
         string "Metadata"
         variant             array [
               dict entry(
                  string "mpris:artUrl"
                  variant                      string "https://i.scdn.co/image/ab67616d0000b2739498ee18bdbdcf28e80ffa05"
               )
               dict entry(
                  string "mpris:length"
                  variant                      int64 169887000
               )
               dict entry(
                  string "mpris:trackid"
                  variant                      object path "/org/ncspot/spotify/track/4EPRCsMgi6sKI68VE6iads"
               )
               dict entry(
                  string "xesam:album"
                  variant                      string "Past Love"
               )
               dict entry(
                  string "xesam:albumArtist"
                  variant                      array [
                        string "Thing"
                     ]
               )
               dict entry(
                  string "xesam:artist"
                  variant                      array [
                        string "Thing"
                     ]
               )
               dict entry(
                  string "xesam:discNumber"
                  variant                      int32 1
               )
               dict entry(
                  string "xesam:title"
                  variant                      string "Past Love"
               )
               dict entry(
                  string "xesam:trackNumber"
                  variant                      int32 1
               )
               dict entry(
                  string "xesam:url"
                  variant                      string "https://open.spotify.com/track/4EPRCsMgi6sKI68VE6iads"
               )
               dict entry(
                  string "xesam:userRating"
                  variant                      double 0
               )
            ]
      )
   ]
   array [
      string "Metadata"
   ]

So at the end there is another array with a string containing Metadata. The same happens when the VolumeChanged signal is emitted. I could imagine this being the culprit, but not 100% sure. Also I don't know how to influence this behavior, yet.

from ncspot.

maru-sama avatar maru-sama commented on July 17, 2024

Hmm this explains why I see the info for a brief second after start. It shows the metadata but then it is getting cleared with the empty array.

from ncspot.

maru-sama avatar maru-sama commented on July 17, 2024

Hmm since it looks like that this is a zbus issue, what about reverting back to zbus 3.15 until it gets fixed?

from ncspot.

hrkfdn avatar hrkfdn commented on July 17, 2024

Looks like a fix is already in zbus, maybe we can update soon! :)

from ncspot.

maru-sama avatar maru-sama commented on July 17, 2024

Thanks I saw it as well, so I guess this will part of an upcoming 4.2.1 release. Since it is just visual issue and nothing breaks because of it I guess this can wait.

from ncspot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.