Giter VIP home page Giter VIP logo

Comments (3)

daviddenton avatar daviddenton commented on June 3, 2024

I think you want to use this:

        returning("XLS" to Response(OK).with(CONTENT_TYPE of OCTET_STREAM))
        returning("JSON" to Response(OK).with(CONTENT_TYPE of APPLICATION_JSON))

Which generates in the output:

 "responses": {
          "200": {
            "description": "JSON,XLS",
            "content": {
              "application/json": {
                "schema": {
                }
              },
              "application/octet-stream": {
                "schema": {
                }
              }
            }
          }
        }

I think this should work, so closing. Please reopen if you need to :)

from http4k.

hstaszek avatar hstaszek commented on June 3, 2024

Well, not exactly. For

returning("PDF" to Response(OK).with(CONTENT_TYPE of APPLICATION_PDF))

we'll have

        "responses": {
          "200": {
            "description": "PDF",
            "content": {
              "application/pdf": {
                "schema": {
                }
              }
            }
          }
        },

and we're missing the schema bit that is described in OpenAPI docs. Even in your examples your octet-stream lacks the schema: type: string format: binary bit.

I think it may be problematic not to able to be generate the spec in a way it's described in OpenAPI docs, other tools that depend on that may fail

from http4k.

hstaszek avatar hstaszek commented on June 3, 2024

And I cannot reopen the issue, don't have the button anywhere @daviddenton

from http4k.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.