Giter VIP home page Giter VIP logo

Comments (14)

damian-kolakowski avatar damian-kolakowski commented on May 5, 2024

Let me check this

from swifter.

FrithjofMatthiasSchaefer avatar FrithjofMatthiasSchaefer commented on May 5, 2024

i fixed the code to work with the current swift compiler version. i am quite new to github. if you tell me how, i can submit my changes.

from swifter.

curveddesign avatar curveddesign commented on May 5, 2024

nicecoding, I am not the best at submitting changes either but this may help...

https://github.com/blog/1862-introducing-a-simpler-faster-github-for-mac

https://mac.github.com/

from swifter.

FrithjofMatthiasSchaefer avatar FrithjofMatthiasSchaefer commented on May 5, 2024

Thanks for your answer!

well i know how to commit changes and push them to a remote github repo via command line. i am just wondering if I will need some kind of access or can I just push into this repo without extra permission?

from swifter.

damian-kolakowski avatar damian-kolakowski commented on May 5, 2024

@nicecoding here you have tutorial how to create a pull request.
https://help.github.com/articles/using-pull-requests/
when you are done, I can merge it :)

The problem here is Swift stopped to support multiple subscripts :/ I need to double check but it looks like it's not possible to define following subscripts:
subscript (path: String) -> Handler?
subscript (path: String) -> String?

from swifter.

FrithjofMatthiasSchaefer avatar FrithjofMatthiasSchaefer commented on May 5, 2024

I already forked your repo and pushed my commits. You need to pull, right?

I simply refactored the class HttpServer and introduced a new Class "HttpServerHandler"

I also changed other compile errors where static initializers where replaced with new constructors /initializers

so now you have to write (which I find even more "readable"):

server.handler["/myFilterPath"] = { response .... }

from swifter.

damian-kolakowski avatar damian-kolakowski commented on May 5, 2024

@nicecoding you can just push it. I will be notified by GitHub :)

from swifter.

FrithjofMatthiasSchaefer avatar FrithjofMatthiasSchaefer commented on May 5, 2024

into my fork or your repo?

-> my fork is already up to date. i pushed minutes ago

from swifter.

FrithjofMatthiasSchaefer avatar FrithjofMatthiasSchaefer commented on May 5, 2024

so i guess i now made a pull request to you. hope that works :-)

from swifter.

FrithjofMatthiasSchaefer avatar FrithjofMatthiasSchaefer commented on May 5, 2024

I am trying to get the server serve file content etc. as raw bytes to e.g. serve images etc. as soon as I am done I ll send you another pull request

from swifter.

damian-kolakowski avatar damian-kolakowski commented on May 5, 2024

@nicecoding I think I was doing the same :) could you please update the push request ?

from swifter.

FrithjofMatthiasSchaefer avatar FrithjofMatthiasSchaefer commented on May 5, 2024

@glock45 I already made a pull request. I dont know what you mean with "push request". That's my first time doing stuff like that on github. Please tell me what to do

from swifter.

damian-kolakowski avatar damian-kolakowski commented on May 5, 2024

@nicecoding I see it but in the same time you were doing changes I did my own changes :) you need to merge your repo with my recent changes from this repo and create another pull request.

from swifter.

FrithjofMatthiasSchaefer avatar FrithjofMatthiasSchaefer commented on May 5, 2024

alright, I saw you just commented out the subscript with type String? I refactored The handler... I dunno which solution is better. I didnt change anything else but some language changes that lead to an compile error. If I should still merge, tell me

from swifter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.