What is the correct way to link an external style sheet file about swifter HOT 12 CLOSED

hi @roman-yu

could you please give me a screenshot from Target -> Build Phases -> Copy Files settings section ?

best
dk

from swifter.

there is a problem with paths in swifter.
now
server["/resources/:file"] = HttpHandlers.directory(publicDir)
matchs resources/file.css but not resources/css/file.css

this could be fixed with something like
server["/resources/:path"] = HttpHandlers.directory(publicDir) server["/resources/:folder/:file"] = HttpHandlers.directory(publicDir)

but since 8fecb35 this would be a little compilicated.

from swifter.

Below is my project structure, please take a look:

from swifter.

@roman-yu you should take a look at my fork of this project https://github.com/tannernelson/vapor

It has a Public folder where you can easily put all of your style sheets / images that you want publicly available.

from swifter.

@roman-yu thanks for the feedback. You are right. It does not work. I fixed it here: 25e9da7

I am going to release a new version - 1.1.0 with other cool stuff.

@tannernelson You did not fork Swifter. You copied source files without license headers.

from swifter.

This is a great idea! However it is not released in 1.0.9, it probably going to be released in 1.0.10. Because 25e9da7 is not tagged with "1.0.9".

from swifter.

@nrmtrifork 👍 (I've updated my previous comment).

from swifter.

@glock45 There's attribution in the README. I can put the license headers back in the files from this repo. They just seem a little redundant to me.

from swifter.

@tannernelson Yes, please do that. I believe in your good intentions but there are more examples of how you break the rules:

I see copy of @johnno1962 's NSLinux ( https://github.com/johnno1962/NSLinux/blob/master/Sources/Dispatch.swift#L48 ) at your repo ( https://github.com/tannernelson/vapor/blob/master/Sources/LinuxFixes.swift#L156 ). No attribution.

I think you are about to start professional carrier and you don't really pay attention to the licensing. Please think about all those guys from here who spend long evenings to make it work.

It would be much easier for you if you make GitHub fork. There are really cool features coming to Swifter.

from swifter.

@glock45 Very good point–you're right.

vapor/vapor@7dc5174

As for forking, Vapor's Response class is already too different to take advantage of re-basing or merging updates from the forked repo I think.

But I'm going to continue watching this repo and contributing for sure. I'm excited to see what's in store.

from swifter.

@tannernelson 👍 thanks man

from swifter.

@glock45, that's great, looking forward to the new version!

@tannernelson, thanks I will take a look.

from swifter.