Terminal Intercepting crashes when using NodeJS worker threads about httptoolkit-server HOT 3 CLOSED

Yup, that patch fixes the issue for me!

from httptoolkit-server.

After some investigation, it turns out that you are setting the envoirement variable http_proxy, but in code attempt to access it as HTTP_PROXY.

Technically, we're setting both, here:

That said, it totally makes sense to me that Windows collapses these into a single variable when it ignores case, and then that Node bug (thanks for filing that!) makes it case sensitive to the selected result.

I don't want to overcomplicate this (e.g. to handle all possible casings) since in theory the current approach is 'correct' (set both vars, read one of them, expect that to be set) and it seems there's a proper fix en route for the specific node bug anyway. For now, I've just added the simplest fix, which should resolve this for your specific Undici issue and also various other cases (e.g. global-agent reads HTTP_PROXY internally I think, which is presumably broken as well, though not actually crashing).

I've pushed that here: 0a3d0af. Can you give that a quick test and confirm it works for you?

from httptoolkit-server.

and it seems there's a proper fix en route for the specific node bug anyway.

Sadly it seems that the NodeJS team has decided to add this behavior to the docs instead of fixing it.
nodejs/node#49008
nodejs/node#48976 (review)

from httptoolkit-server.