Cannot deep copy ECC type tls.Certificate on Go v1.16.4 about go-clone HOT 6 CLOSED

UPDATE: Neither MarkAsScalar or SetCustomFunc works on pointer types. I cannot use current mechanism to fix this issue. I need to add a new API MarkAsOpaquePointer to fix this issue.

from go-clone.

Can you please provide a demo to reproduce this issue? It can help me to understand this issue much better. Thanks.

from go-clone.

func deepCopyCert(cert *tls.Certificate) *tls.Certificate {
	return clone.Clone(cert).(*tls.Certificate)
}

Deep copy the certificate(ECC type) and return the new one like the code above. When using the returning certificate, it will fail to handshake with error:

tls: unsupported certificate curve (P-256)

Search the error tls: unsupported certificate curve in golang source code, locate to:

https://github.com/golang/go/blob/0410005dc458f23fb15f64354f9a24ca8f2fe044/src/crypto/tls/auth.go#L268-L282

from go-clone.

The root cause is that package crypto/tls validates the curve of a certificate public key by pointer rather than by value. I can mark elliptic.CurveParams as scalar to solve this problem.

from go-clone.

Tag v1.3.0 is pushed to fix this issue.

from go-clone.

Thanks!

from go-clone.