Giter VIP home page Giter VIP logo

Comments (7)

gdehmlow avatar gdehmlow commented on May 26, 2024

I think there will also be a similar problem here:

entityId = Entity.create('LINK', 'MUTABLE', {url: href});

from draft-convert.

gdehmlow avatar gdehmlow commented on May 26, 2024

And here's a rough draft (ha): #5

from draft-convert.

benbriggs avatar benbriggs commented on May 26, 2024

Interesting...there shouldn't be another copy of Draft floating around since it's declared as an external. To confirm, in htmlToEntity you're returning the return value of Entity.create (the string key), not the Entity instance itself? If so, could you provide a test that runs into this issue and fails on the current version that will pass with your PR? Though it might be hard to repro the issue in a test if the problem is using it in another project.

Completely agreed that having entity data in content state will solve a lot of problems!

from draft-convert.

gdehmlow avatar gdehmlow commented on May 26, 2024

Yep I'm returning the string.

I didn't check the webpack config.. it does appear to be external. However, in my compiled vendor.js, I definitely have two copies of DraftEntity, and when I'm converting the HTML to Draft, it's using one of them to add and get entities from the map, and then when I'm converting the draft to HTML, it's using the other get.

This may then be a problem with my webpack. I'll look into it some more.

from draft-convert.

gdehmlow avatar gdehmlow commented on May 26, 2024

Okay I managed to resolve this issue by bumping the draft-js version in draft-convert from 0.6.0 to 0.7.0, which is the version I'm using in my project.

from draft-convert.

benbriggs avatar benbriggs commented on May 26, 2024

Weird! I should stay up to date with the current version anyways so I'll put up a patch with the correct Draft version.

from draft-convert.

gdehmlow avatar gdehmlow commented on May 26, 2024

Thank you! But yeah, really strange. I don't know enough about webpack to understand why this would happen, and it's not clear to me if it's a problem on my end or if this is the way externals work

from draft-convert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.