Comments (7)
I think there will also be a similar problem here:
draft-convert/src/convertFromHTML.js
Line 381 in ca47c05
from draft-convert.
And here's a rough draft (ha): #5
from draft-convert.
Interesting...there shouldn't be another copy of Draft floating around since it's declared as an external. To confirm, in htmlToEntity
you're returning the return value of Entity.create
(the string key), not the Entity
instance itself? If so, could you provide a test that runs into this issue and fails on the current version that will pass with your PR? Though it might be hard to repro the issue in a test if the problem is using it in another project.
Completely agreed that having entity data in content state will solve a lot of problems!
from draft-convert.
Yep I'm returning the string.
I didn't check the webpack config.. it does appear to be external. However, in my compiled vendor.js
, I definitely have two copies of DraftEntity
, and when I'm converting the HTML to Draft, it's using one of them to add
and get
entities from the map, and then when I'm converting the draft to HTML, it's using the other get.
This may then be a problem with my webpack. I'll look into it some more.
from draft-convert.
Okay I managed to resolve this issue by bumping the draft-js version in draft-convert from 0.6.0
to 0.7.0
, which is the version I'm using in my project.
from draft-convert.
Weird! I should stay up to date with the current version anyways so I'll put up a patch with the correct Draft version.
from draft-convert.
Thank you! But yeah, really strange. I don't know enough about webpack to understand why this would happen, and it's not clear to me if it's a problem on my end or if this is the way externals work
from draft-convert.
Related Issues (20)
- Feature suggestion: convertToJSX
- convertToHTML Anchor Tag HOT 1
- When converting html with hyperlink, spaces is removed.
- TypeScript: Argument of type 'htmlConverter' is not assignable to parameter of type 'ContentState'.
- soft enters are not persisted when pasting text entered in draft.js editor
- After convertFromHtml span with whitespace doesn't keep the inline styles
- Possible bug in the readme example (entityToHTML) HOT 4
- convertToHTML throws for "code-block" HOT 4
- Empty block when using iframe
- Error for code-block, no list and no font size change
- v2.1.11 -> v2.1.12 extra spaces HOT 1
- disable default behavior of list elements being wrapped in ul/ol HOT 2
- List Items rendered without <ul> or <li> HOT 1
- convertFromHTML and inline images
- How to map code
- Handle empty lines when converting to HTML
- peerDependencies to support React v18 HOT 3
- convertFromHTML adds <br/> to blockquotes HOT 1
- Encounter "ReferenceError: document is not defined" when call convertFromHTML() on Node.js server side
- Display of spans
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from draft-convert.