Giter VIP home page Giter VIP logo

Comments (10)

adamschwartz avatar adamschwartz commented on July 21, 2024 1

@zackbloom thoughts on the right approach here? Triggering a th.click() is the current strawman.

from sortable.

jmduke avatar jmduke commented on July 21, 2024

Implemented a lazy proof of concept of this here for my own use:

https://github.com/jmduke/sortable

I think refactoring the main function so its less anonymous would be a more semantic way to do this -- that way we could pass it a th and maybe a direction parameter, and access it outside the scope of the onClick handler. Thoughts?

from sortable.

adamschwartz avatar adamschwartz commented on July 21, 2024

@jmduke thanks for the POC. I think you're right that a refactor is probably needed to do this the right way.

from sortable.

eytanbiala avatar eytanbiala commented on July 21, 2024

+1

from sortable.

kevinahuber avatar kevinahuber commented on July 21, 2024

+1

from sortable.

visola avatar visola commented on July 21, 2024

Hey @adamschwartz, I was thining about submitting a PR for this today. My idea was to extract the sorting logic in the event handler to a sort method and bind it to Sortable inside the event handler. Then we can call it from the init method like @jmduke did in his implementation. Instead of calling click we could just call that method.
I'm working on the PR right now. I'll submit it in a few minutes.

from sortable.

adamschwartz avatar adamschwartz commented on July 21, 2024

Thanks @visola we’ll take a look!

from sortable.

Dunky13 avatar Dunky13 commented on July 21, 2024

Any updates? Would be nice

from sortable.

interrogator avatar interrogator commented on July 21, 2024

@adamschwartz Anything happening with the PR?

from sortable.

adamschwartz avatar adamschwartz commented on July 21, 2024

@interrogator Unfortunately I have not had time to follow up on this issue. Please feel free to reach out to other members of the @HubSpot org who may be able to help.

from sortable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.