[Bug]: Page scrolling when space bar is pressed about sd-webui-openpose-editor HOT 24 CLOSED

Will fix on next release.

from sd-webui-openpose-editor.

I am going to reconsider keybinding if at least 1 other user report the same problem with SPACE key.

from sd-webui-openpose-editor.

So ... I'm maybe doomed to not be able to use this ... ?! 😧

from sd-webui-openpose-editor.

So ... I'm maybe doomed to not be able to use this ... ?! 😧

I suspect it might be related to firefox? I will test it on firefox later today trying to reproduce it. If I cannot reproduce it, I cannot fix it. The fallback would be change the keybinding, which can be a little bit distrubing.

Also, can you reproduce it on another browser Chrome/Edge, etc?

from sd-webui-openpose-editor.

Unfortunately I have no other browser installed. 😔
All I can say, is, that it is a new profile with almost no extensions or ad blockers, stricktly for SD.
The problem with the space bar in web browser is probably the reason, why canvas-zoom did not used it and chose another key. 😐

from sd-webui-openpose-editor.

Bug confirmed on Firefox.

from sd-webui-openpose-editor.

Well, the bug not only happens on firefox. It happens on all platforms. If you enter the iframe and directly press space (without doing another other interactions such as click on frame), the browser seems to resend the previous frame message to the iframe, which will cause the editor clear the canvas and redraw everything.

from sd-webui-openpose-editor.

https://stackoverflow.com/questions/369026/setting-focus-to-iframe-contents
Potential solution.

Need to fix on ControlNet side.

from sd-webui-openpose-editor.

Fixed.

from sd-webui-openpose-editor.

Cool! Will check ASAP.

Edit:
Unfortunately it still scrolls. 😞
FF 114
And the modal box is still overlapping.
Any ideas?

from sd-webui-openpose-editor.

Are you sure you have the controlnet side patch installed? Need controlnet version 1.1.220+.

Can you share a screenshot of modal overlapping as well?

from sd-webui-openpose-editor.

Yes, CN is the latest v1.1.220

from sd-webui-openpose-editor.

Yes, CN it the latest v1.1.220

The UI seems ok in my perspective. Also, when you press space, the iframe scrolls or the main frame a1111 scrolls? Is there a specific sequence of operations to reproduce the scroll?

from sd-webui-openpose-editor.

Chinese display error, the text is some symbols

from sd-webui-openpose-editor.

The UI seems ok in my perspective.

Uum ... don't you see the scrollbar on the right? It's caused by the modal being higher than the page itself. This whole white box should fit into the window. And the scrolling content should be what's inside of it.
It should look like this:

The problem seems to be on that the iframe being positioned absolute which makes margins useless. 100vh is therefore not appropriate for this because height calculations then are off. 😕
If you want/need, I could setup a html/css template for you.

Also, when you press space, the iframe scrolls or the main frame a1111 scrolls?

The iframe is scrolling. The main outside stays at it is.

Is there a specific sequence of operations to reproduce the scroll?

No, absolutely not. I click "edit" in A1111, the modal comes up, I click into it and when I press space, the iframe scrolls down.

from sd-webui-openpose-editor.

If you already have the correction in mind, I am happy to merge your PR in ControlNet repo. The modal code is mostly generated by ChatGPT and I stop iterating when the appearnce satisfies my need.

I guess if I cannot reproduce the issue, I will just add another alt keybinding to panning, make it possible to pan using both SPACE key and F key.

from sd-webui-openpose-editor.

Chinese display error, the text is some symbols

Can you submit separate issue and attach some screenshots?

from sd-webui-openpose-editor.

If you already have the correction in mind, I am happy to merge your PR in ControlNet repo.

Sorry, I'm just a github user, no contributer. I don't even know how this works ... 😁
But I can zip you the html templates and you can copy the CSS where it fits/needs to be.

The modal code is mostly generated by ChatGPT and I stop iterating when the appearnce satisfies my need.

That's why it is so bad ... 😁 You should never let do this a dumb machine. Always ask an expert. 😊
Is the code also from ChatGPT ... ? That would explain a lot ... 🙄

I guess if I cannot reproduce the issue, I will just add another alt keybinding to panning, make it possible to pan using both SPACE key and F key.

This would be great. 👍 With that, we could also check if it's in deed a problem with the space bar.

from sd-webui-openpose-editor.

Pan with key F enabled in v0.0.17. You can try whether key F is working for you now.

from sd-webui-openpose-editor.

Is F + mousewheel scroll used to zoom?

Update:
OK, a good and a bad message:
The good one: It's working. 🎉🎉
The bad one: Only after I discovered, that "updating the extension" obviously does not update the content of the dist folder.
On your repo page you write:

On UI restart, the extension will try to download the compiled Vue app from Github. Check whether stable-diffusion-webui\extensions\sd-webui-openpose-editor\dist exists and has content in it.

Some users in China have reported having issue downloading dist with the autoupdate script. In such situtations, the user has 2 following options to get dist manually:

Obviously this is a general issue. Maybe you check if this can be fixed.
Other than that, great work. Now it only have to look "good". 😋
Thanks! 👍

from sd-webui-openpose-editor.

Modal style fixed in Mikubill/sd-webui-controlnet#1623.

from sd-webui-openpose-editor.

Great! 👍
Is a update sufficient or do we also need to download the dist folder ... ?

from sd-webui-openpose-editor.

Great! 👍 Is a update sufficient or do we also need to download the dist folder ... ?

This change is on ControlNet extension so all you need to do is to update the ControlNet extension. So the autoupdate script is not working for you? You can check the version by inspecting dist/version.txt. When you update the repo the dist directory will not update. It will be updated when you launch the WebUI.

If you meet any difficulties on the autoupdate feature (Other than network issue with Github), I would encourage you file a new issue for it.

from sd-webui-openpose-editor.

BTW, recent updates of the editor solved a major problem in v0.1.0+, which allows you to scale/rotate grouped objects. I strongly encourage you to update if you have not done so.

from sd-webui-openpose-editor.