Comments (4)
kawine
commented on June 26, 2024
1
Thanks for pointing this out @seanexp !
This looks like a bug, since I was under the (incorrect) impression that interleaving datasets with all_exhausted would preserve the relative size of the original datasets, which on second look, it appears to not do. Instead, it duplicates the data in an unpredictable way, which we don't want.
The interleaving is also unnecessary, at least in the current version of the code, so I'll make a PR to remove it.
from trl.
seanexp
commented on June 26, 2024
Thanks! @kawine
from trl.
younesbelkada
commented on June 26, 2024
Hi ! This should be fixed by #1499 I believe, do you think we can close this issue?
from trl.
seanexp
commented on June 26, 2024
@younesbelkada Yes, I'll close this issue
from trl.
Related Issues (20)
- UserWarning: Could not find a config file
- concatenated_forward when self.ref_model is not provided HOT 1
- which model should i choose if i wanna try DPO algorithm?
- PPOTrainer behavior with `device_map = "auto"` HOT 1
- None ref_model in ppo train
- FSDP/ZeRO3 Support for QLoRA in DPO?
- Use `SFTTrainer` for completion-only model without `DataCollatorForCompletionOnlyLM`
- `disable_dropout` not used in KTOTrainer
- [question] how to apply model parallism to solve cuda memory error HOT 6
- misleading warning message
- How should I set the SFT label?
- dpo cli command error HOT 4
- [question] Differences in hh-rlhf datasets between versions 0.8.1 and 0.8.2.dev0
- DPOTrainer tokenization fails after 30 minutes HOT 1
- Feature Request: DNO
- a bug which leads to "Cuda: Out of memory" in CPOTrainer (cpo_trainer.py), trl 0.8.1 0.8.2, please fix this bug
- Why PPO/DDPO inherits the BaseTrainer class instead of the trainer class?
- setting compute metrics on SFTTrainer but "RuntimeError: Sizes of tensors must match except in dimension 0. Expected size 102 but got size 212 for tensor number 1 in the list."
- [Question] ORPOTrainer and CPOTrainer looks very similar
- Bug in example DPO script in dataloading
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trl.