Giter VIP home page Giter VIP logo

Comments (3)

danhumaan avatar danhumaan commented on August 10, 2024

Thanks @Veyfeyken this is really great feedback. We'll investigate this further and work it in as a priority in the next release!

from modaal.

AndrewArch avatar AndrewArch commented on August 10, 2024

Further to @Veyfeyken's comment, I found I was able to tab out of the modal and lost keyboard focus - ended up in the address bar and then somewhere on the background page before re-entering the modal.

from modaal.

danhumaan avatar danhumaan commented on August 10, 2024

Hi @Veyfeyken, thanks again for your contribution. We've spent some time investigation the focus states as well as applied some fixes for when users could tab away from the modal. Strictly speaking we haven't added the aria-hidden attribute, however we believe this issue has been fixed via other means in the latest release.

@AndrewArch, the behaviour of allowing the focus to move out of the page and into the application frame, such as address bar, is something that we want to retain. If we override this we'll likely only be doing more harm to keyboard users, and users with assistive technologies by locking them into the content, subsequently not allowing them to continue on onto other tasks outside the website.

from modaal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.