Giter VIP home page Giter VIP logo

Comments (2)

danhumaan avatar danhumaan commented on September 15, 2024

hi @bersujamu Thanks for your patience and apologies for the delay and in reposnding. This is something we've been putting some more thought into recently as a way of further extending Modaal's functionality.

The challenge we're facing currently is how we handle focus states, specifically where do we shift the focus state back to on close for an item that isn't a modaal.

This is the scenario we're planning out: You're currently focused on element A at the top of the page, you scroll down the page so element A is now out of the viewport and interact with element B in a way that won't move your focus to element B, but will open a Modaal dialog. When you close that Modaal dialog, we need to reset the focus, which in this case is element A so the page scrolls back up to focus on element A. Not ideal for the user because you moved past that point and we would ideally allow you to continue where you opened the Modaal from, not somewhere else on the page.

As we get further in working out how to best handle this we'll address this task in conjunction with others and update as required.

Thanks again, and keep watching this space for more updates.

from modaal.

danhumaan avatar danhumaan commented on September 15, 2024

It's been a long time coming, but I've just implemented support for non <a href="#"> triggers such as button, with a new content_source options. See the readme for more detailed documentation, but this can now be used like:

<button class="inline">Show</button>
$('.inline').modaal({
    content_source: '#inline'
});

or for inline attribute application

<button data-modaal-content-source="#inline" class="modaal">Show</button>

from modaal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.