Improving speed about brightnessctl HOT 6 CLOSED

What do you mean by "slow", how do you use brightnessctl ?

Since changing the brightness is inherently a privileged operation, we need an escalation mechanism and most distributions should be using the logind's DBus interface witch is slow-ish.

You can try to run brightnessctl as root to see if its "fast"

from brightnessctl.

I am not implying that it takes seconds to run, just that it takes more time compared to other solutions I have experienced.

Simple timings via time took around 10-20ms (poor benchmark, yes) on my system on Arch Linux with Skylake. In comparison to the very simple light, it does feel a lot slower. I haven't benchmarked the latter.

It is understandable that it relies on other stuff that may be bottlenecks, but my question is more if anything actually can be sped up, or that if the current solution does not allow for significant speedups.

from brightnessctl.

@albinahlback when not specifying a device, brightnessctl still reads all devices even though it then takes only one.
We also have a uname call to make sure we're on linux which probably doesn't make sense in runtime.
Additionally, you should install udev rules for better performance (and not go through the dbus stuff).
When reading the device, iterating readdir output instead of directly trying to access necessary dirs may be inefficient too.

from brightnessctl.

@albinahlback
Check out #103
How does it feel?
From a cursory glance with hyperfine, it should be a little faster than light (haha) now.

from brightnessctl.

Yes, that does feel a lot faster! Thanks!

from brightnessctl.

Fixed

from brightnessctl.