line margin `-l` does not work with 0 about comby-search HOT 3 CLOSED

Hey, thank you so much for the feedback! I've pushed a new commit to fix this issue.

With -l 0:

With -l 2:

Regarding the issue that outputs don't match for 1 & 2, I think it's an expected behavior, since the match is at the top of the file, the case -l 1 should show the match at line 2, and line 1 and 3 as a margin. The case -l 2, it should show the margin lines up to line 4 in the bottom, and on top, the minimum will be line 1, right? Or I missed anything? :D

from comby-search.

Hey @huytd,

Thank you so much for the fix. I will pull the latest version and test it out.

Yep, I rechecked for the cases of -l 1 & 2, and it makes sense. I'll strikethrough the issue description since its not a bug.

Closing the issue since it's fixed.

from comby-search.

Tested and it works perfectly.

$ cb -l 0 -f '*.txt' 'cat'  
test.txt
   2 │ cat
$ cb -l 1 -f '*.txt' 'cat'
test.txt
   1 │ a
   2 │ cat
   3 │ in

from comby-search.