Changes to behavior of `runtime_checkable()` in py 3.12 about structlog HOT 6 CLOSED

please lmk if you run into other similar issues!

Will do!

Is this issue something that blocks you?

No, we swapped out the isinstance() with an inspection of the repr to the same effect. Once you cut next release I'll change it back but we are on our way for now :)

from structlog.

The vanilla get_logger returns an Any, I suspect that's more likely to be the issue? See also https://www.structlog.org/en/stable/typing.html

from structlog.

This isn't a static typing issue. It is a runtime issue on python 3.12 where the BindableLogger protocol (which is marked @runtime_checkable) returns False on an isinstance() check against an instance of BoundLoggerLazyProxy.

from structlog.

Ah yes sorry ugh this is ugly I'll see what we can do.

from structlog.

Thanks @hynek!

from structlog.

This should be fixed by #561 – please lmk if you run into other similar issues!

Is this issue something that blocks you?

from structlog.