Comments (3)
Yeah that does not seem to be too good. I think we have three solutions but they all have some disadvantages
- Expose
string_free
publicly and allow the consumer to deal with it.
- Downside is that this is quite the uncommon pattern in JS and likely they will still forget some allocations.
- Within the wrapper copy the value and immediately call it (it might even already be copied
ffi-napi
and c++ side).
- Would still require all manual frees but at least we control it and not the consumer.
- Wait for Typescript 5.2 to be stable as it introduces the
using
keyword which would finally allow a cleanup function to be ran when it goes out-of-scope.
- The best option by far, but I am unsure of the timeline (microsoft/TypeScript#54298).
IMO it is okay to wait for typeScript 5.2 and leave this as-is for now.
from anoncreds-rs.
3. Wait for Typescript 5.2 to be stable as it introduces the
using
keyword which would finally allow a cleanup function to be ran when it goes out-of-scope.
- The best option by far, but I am unsure of the timeline (TypeScript 5.2 Iteration Plan microsoft/TypeScript#54298).
Well, if that iteration plan is accurate, it will be out in 4 days from now! So definitely it's worth waiting a bit and doing not only this but also for object handle clear() methods.
If not, I'd go for option 2.
from anoncreds-rs.
I think the wrapper copies these FFI string buffers to Strings anyway, so it should be possible to free the reference before returning. I noticed later that this would apply to anoncreds_buffer_free
as well, for binary buffers.
from anoncreds-rs.
Related Issues (20)
- @hyperledger/anoncreds-nodejs invalid reference to binary v0.2.0-dev.5 HOT 1
- release assets HOT 2
- Non revocation proof cannot be parsed by Indy-SDK HOT 3
- Issuing credentials with optional values HOT 5
- Proofs created between AnonCreds RS and Indy SDK are different HOT 15
- Should `id` be included in AnonCreds W3C credential, or is it 'valid' to only include it in the W3C credential HOT 2
- Numbers should be included as numbers in the AnonCreds W3C VC HOT 1
- Relax DID validation on prover_did on a credential request HOT 3
- W3C CredentialSubjectId property not set correctly HOT 2
- Revocation Registry ID validation is failing HOT 6
- Data Integrity Proof Cryptosuite naming HOT 5
- Update AnonCreds Data Integrity Proof docs for the new cryptosuite value
- Initially created W3cCredential uses string for number values HOT 3
- Security best practices for verifying AnonCreds W3C VPs HOT 2
- Conversion from W3cVerifiableCredential to the legacy format fails HOT 2
- Getting an error when try to create Schema via NodeJS Wrapper HOT 2
- Revoking one credential of many, of the same type, creates failed proofs for all credentials. HOT 13
- Using index 0 for issuing a credential gives "AnoncredsError: Invalid state: Revocation index is outside of valid range" HOT 2
- iOS crashes when built in release mode HOT 4
- Schema claims are optional, but creating a proof for a credential with optional claims fails
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from anoncreds-rs.