Comments (5)
Oh wow. This looks like a perfect solution to do a looser string matching. I will incorporate the same with a variable input of similarity ratio. Thanks @petermetz for the insights
from cacti.
I am working on this
from cacti.
@petermetz I will make the checks looser while keeping the check relevant (It would be very irritating working on a task, creating a PR and then getting stuck comparing and fixing the PR and the related commit.)
from cacti.
@jagpreetsinghsasan Thank you for the work on the improvements in advance! I thought about it a little more and would strongly recommend to refactor it to be less strict by only demanding a certain level of string similarity, otherwise it will probably just end up being super annoying 90% of the time for contributors in the cases when they just have some silly typo making a difference.
I found this library that looks very versatile and perfect for the task:
https://www.npmjs.com/package/string-similarity-js
Specifically I would recommend the custom check to have a 90% (0.9
) similarity ratio demand by default (so maybe they won't be the exact same but as long as at least they are mostly the same we can be OK with it as a best-of-both-worlds tradeoff.
The other thing: It would be very handy to be able to configure the threshold from an env variable so that later on if we find that a higher or lower threshold is better, we don't have to touch the code at all just set the env var in ci.yaml or somewhere else where the job is defined (technically still a code-change I know, but it's in the yaml not in the actual logic)
from cacti.
@jagpreetsinghsasan You got it! Thank you as well!
from cacti.
Related Issues (20)
- perf(build): reduce redundant OpenAPI generator executions in codegen
- fix(connector-besu): do not crash if ledger unreachable - send HTTP 503 HOT 5
- docs(connector-ethereum): fix Testing API calls with container tutorial HOT 2
- docs(connector-fabric): fix API call testing tutorial in README.md
- ci(connector-xdai): fix docker rate limit issues with openethereum image pull
- feat(daml): test tooling class HOT 1
- feat(corda): dockerfile update to include cordapps
- test: refactor try-catch based negative scenarios with Jest matchers HOT 2
- test(plugin-htlc-coordinator-besu): use Jest error assert in refund.test HOT 4
- ci(github): upgrade actions/github-script to 7.0.1 project-wide
- test(besu): refactor jest test negative test cases HOT 4
- ci(github): commit parity check to ignore dependabot pull requests
- test(fabric): refactor jest test negative test cases
- test(aries): refactor jest test negative test cases
- test(ethereum): refactor jest test negative test cases HOT 1
- ci(github): upgrade [email protected] [email protected] [email protected]
- test: refactor jest test negative test cases - phase 1
- test(ethereum): fix broken validations in cactus-plugin-ledger-connector-ethereum tests
- feat(daml): creation of connector class
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cacti.