Giter VIP home page Giter VIP logo

Comments (5)

denyeart avatar denyeart commented on August 24, 2024

A recent github.com/IBM/mathlib update introduced an architecture specific build tag.

I see that a "generic" implementation for mul() is available here:
https://github.com/IBM/mathlib/blob/main/driver/kilic/custom_generic.go#L53

This file has a build tag of //go:build !amd64 || generic:
https://github.com/IBM/mathlib/blob/main/driver/kilic/custom_generic.go#L1

Based on that build constraint, I would expect architectures besides amd64 to use the generic implementation automatically. But maybe the "generic" build tag needs to be explicitly passed?

@ale-linux Any ideas? What was the intent for architectures besides amd64?

from fabric-ca.

denyeart avatar denyeart commented on August 24, 2024

Thanks to @ale-linux investigation, we found that updating github.com/IBM/mathlib to v0.0.3-0.20231011094432-44ee0eb539da resolves the problem. PR #387 opened.

Note that it can be tested on other platforms by doing:

env GOOS=linux GOARCH=s390x make clean fabric-ca-client
and
env GOOS=linux GOARCH=s390x make clean fabric-ca-server

from fabric-ca.

denyeart avatar denyeart commented on August 24, 2024

@silliman @asararatnakar @benjsmi Fix has been merged into fabric-ca main branch. Can you try a s390x build from main branch, and if it looks good, we can release v1.5.8 with the fix.

from fabric-ca.

asararatnakar avatar asararatnakar commented on August 24, 2024

@denyeart Thank you for the follow up Dave. We were able to build s390x from main branch.

from fabric-ca.

silliman avatar silliman commented on August 24, 2024

This builds fine now on s390x. I successfully ran the fabric-samples/test-network (with -ca argument) with the built fabric-ca OCI image. Thanks for the fix!

from fabric-ca.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.