Giter VIP home page Giter VIP logo

Comments (6)

pimentel08 avatar pimentel08 commented on May 24, 2024

No UI change.

UX Change: When user selects "MetaMask Extension", the web view (80%) will open up to start MM onboarding. After they have successfully logged in to MM, the MM modal will appear.

Will the modal be movable? TBD

from hyperplay-desktop-client.

BrettCleary avatar BrettCleary commented on May 24, 2024

We are currently doing this through a separate window since we can't use a webview tag to embed it in the React DOM tree (because it is sandboxed and doesn't have access to our chrome extended api) and have to use an electron Browser View. This also is the best pattern as the chrome event we are handling is a generic 'createTab' event that can be called for multiple purposes (e.g. the portfolio view). Furthermore Electron specifically recommends to not use the webview tag as it is unstable https://www.electronjs.org/docs/latest/api/webview-tag.

from hyperplay-desktop-client.

BrettCleary avatar BrettCleary commented on May 24, 2024

Show the portfolio view and home page links in the sidebar. navigate to these pages when the "createTab" event is called with those html pages.

from hyperplay-desktop-client.

BrettCleary avatar BrettCleary commented on May 24, 2024

Need to investigate how to show the html pages in the react dom since webview tag is sandboxed

from hyperplay-desktop-client.

BrettCleary avatar BrettCleary commented on May 24, 2024

PR in progress here: #83

from hyperplay-desktop-client.

BrettCleary avatar BrettCleary commented on May 24, 2024

I will leave the sidebar like this on this PR and the sidebar UI redesign can be done on a separate PR image.png

from hyperplay-desktop-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.