Comments (6)
No UI change.
UX Change: When user selects "MetaMask Extension", the web view (80%) will open up to start MM onboarding. After they have successfully logged in to MM, the MM modal will appear.
Will the modal be movable? TBD
from hyperplay-desktop-client.
We are currently doing this through a separate window since we can't use a webview tag to embed it in the React DOM tree (because it is sandboxed and doesn't have access to our chrome extended api) and have to use an electron Browser View. This also is the best pattern as the chrome event we are handling is a generic 'createTab' event that can be called for multiple purposes (e.g. the portfolio view). Furthermore Electron specifically recommends to not use the webview tag as it is unstable https://www.electronjs.org/docs/latest/api/webview-tag.
from hyperplay-desktop-client.
Show the portfolio view and home page links in the sidebar. navigate to these pages when the "createTab" event is called with those html pages.
from hyperplay-desktop-client.
Need to investigate how to show the html pages in the react dom since webview tag is sandboxed
from hyperplay-desktop-client.
PR in progress here: #83
from hyperplay-desktop-client.
I will leave the sidebar like this on this PR and the sidebar UI redesign can be done on a separate PR
from hyperplay-desktop-client.
Related Issues (20)
- follow-redirects' Proxy-Authorization header kept across hosts
- Prototype Pollution in JSON5 via Parse Method
- qs vulnerable to Prototype Pollution
- glob-parent vulnerable to Regular Expression Denial of Service in enclosure regex
- Pkg Local Privilege Escalation
- Axios Cross-Site Request Forgery Vulnerability
- [CodeQL] Uncontrolled command line
- [CodeQL] Incomplete regular expression for hostnames
- [CodeQL] Incomplete string escaping or encoding
- [CodeQL] Prototype-polluting function
- [CodeQL] DOM text reinterpreted as HTML
- [CodeQL] Overly permissive regular expression range
- Uninstall Cleanup
- Unable to import MM extension from Chrome after "Secret Recovery" or "New MM Extension"
- WalletConnect does not work
- Unable to install a first time game while in QA Mode
- Attempting to reuse the sign-in redirect breaks "Manage Accounts"
- Overlay buttons do not work on Main
- Display issues with size and ETA for Iron Works
- Unable to auto update Iron Works HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyperplay-desktop-client.