Giter VIP home page Giter VIP logo

Comments (5)

flavioislima avatar flavioislima commented on June 19, 2024

I think we have discussed this in the past.
Both approaches has good and bads.
If we put the temp file on the destination drive, this also means the user will need double the space to install it so it will still breaks if it doesn't.

I'm fine with any approach but that does not solve the root problem.

For this we would need a way to download the game assets in chunks and extract and delete them in real time, so we would need maybe only 1/5 of the game space and would cause less issues.

Maybe something we could try once we have the patch service.

from hyperplay-desktop-client.

awantoch avatar awantoch commented on June 19, 2024

@flavioislima I def agree that it won't fix the root cause of having to download the zip in full before extraction.

However, the current implementation causes a good bit of confusion. Right now the following flow is causing some issues:

  1. Change install path to another drive, say, D:
  2. Click install
  3. Space left is checked on D:
  4. ZIP is downloaded to C:, but the space was not checked on that drive, so the download can fail mid-way when C: is filled

Whereas, if the temp folder was on the same drive as the config'd install path, the player would at least know up-front a bit better, ofc not perfect since we don't know the full extraction size, but it would eliminate a majority of the cases that people are running into.

from hyperplay-desktop-client.

awantoch avatar awantoch commented on June 19, 2024

Looks like this one arises from:

const tempfolder = path.join(configFolder, 'hyperplay', '.temp', appName)

Here, we'll need to pull the temp folder from the settings instead of using appData always

from hyperplay-desktop-client.

awantoch avatar awantoch commented on June 19, 2024

PR: https://github.com/HyperPlay-Gaming/hyperplay-desktop-client/pull/742/files

from hyperplay-desktop-client.

awantoch avatar awantoch commented on June 19, 2024

New PR instead: #744

from hyperplay-desktop-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.