Giter VIP home page Giter VIP logo

Comments (12)

flavioislima avatar flavioislima commented on May 24, 2024 1

The act of Sideload means that you are responsible for the game you are adding since it is manually added.
We could have a list of recommended/curated browser and installable games in the future though. And then auto Add/Install them.

But for this feature, I think the user would be responsible for it.

from hyperplay-desktop-client.

camgreenburg avatar camgreenburg commented on May 24, 2024

@flavioislima Can you help me understand what this looks like in terms of an mvp side-loading feature? What other acceptance criteria would we need here?

from hyperplay-desktop-client.

flavioislima avatar flavioislima commented on May 24, 2024

Sure!

  • It needs to have a way of opening the form to sideload a game
  • This form needs to contain the following fields:
    • Name of App/Game
    • Platform (on Linux and mac this could be native or Windows)
    • Artwork
    • Brief Description
    • Checkbox to mark if it supports web3 transactions
    • Input to select the binary
    • If a Windows app/game on Linux should have Wine and Wineprefix selection options/inputs
    • if a Windows game on macOS, should show the option to select the Crossover Version and Bottle Name.
  • This should be a Modal like the current Install Dialog we have and follow same design guidelines
  • When clicking ok the game should show under the HyperPlay runner filter

That is what I think is necessary for acceptance.

from hyperplay-desktop-client.

camgreenburg avatar camgreenburg commented on May 24, 2024

@flavioislima amazing. Thanks! How will the form accommodate browser-based vs PC games? Is it the same set of info and there would be optional questions like the crossover and OS questions?

Naive question: Can you even side-load a browser game?

from hyperplay-desktop-client.

flavioislima avatar flavioislima commented on May 24, 2024

Nope, browser games we would need to add manually or create another type of sideloading. These would be for games with a binary.

from hyperplay-desktop-client.

camgreenburg avatar camgreenburg commented on May 24, 2024

With browser games is it as simple as pointing our browser to the right url?

from hyperplay-desktop-client.

flavioislima avatar flavioislima commented on May 24, 2024

Yes.
We could in reality add an option for browser games when sideloading. 🤔
So we could open it on an internal webview or external window.

from hyperplay-desktop-client.

camgreenburg avatar camgreenburg commented on May 24, 2024

But with side-loading a PC game you only curate the game locally. With Browser games it would be pretty easy to curate globally so all users of HyperPlay could discover?

This would require some moderation, but would be fairly straightforward it seems to me.

from hyperplay-desktop-client.

flavioislima avatar flavioislima commented on May 24, 2024

Current DRAFT of the screen on Heroic (adding a Windows game on Linux):
image

The main functionality is almost finished, just need better design on this one, margins, image position, etc.
also to decide the titles etc.
Besides what we talked about above, I added a button to run an installer before adding the app/game, in case the user wants to first run the setup.

@biliesilva

from hyperplay-desktop-client.

flavioislima avatar flavioislima commented on May 24, 2024

PR on Heroic repo:
Heroic-Games-Launcher/HeroicGamesLauncher#1864

from hyperplay-desktop-client.

biliesilva avatar biliesilva commented on May 24, 2024

It can be improved a little more, using some more space between elements and aligning the card with the first element of the right side, also adding the same corner radius that we are using for the buttons and input boxes (I've added 4px here):
wir

spaces:
image

Others adjust:

image

from hyperplay-desktop-client.

flavioislima avatar flavioislima commented on May 24, 2024

ok, thanks. Will update the UI acordling.

from hyperplay-desktop-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.