Giter VIP home page Giter VIP logo

Comments (10)

matthiasharrer avatar matthiasharrer commented on June 5, 2024 10

Hi,

after using the Mi Home app for a while, I am back working on the zone selection stuff here and then (Having fresh ideas :).

I would like to have the zone selection map somehow integrated with the rest of the frontend (If anyone is more fluent in OnsenUI that might help).
Also I think using the map directly for showing and changing the saved zones would be nice!

Here is what it looks like right now (https://github.com/matthiasharrer/Valetudo/tree/map-rework):
Window Resize is still not handled and the displayed coordinates are not updated when moving/resizing the map.

improved-zone-selection

from valetudo.

cryptomilk avatar cryptomilk commented on June 5, 2024 2

A zone feature has been added if if you build from source install the new version and go to: http://rockrobo/zone

from valetudo.

stefanct avatar stefanct commented on June 5, 2024 1

No, it's not a big issue of course but I was asking because @Hypfer closed the bug and I think we should still track it in case anybody looks for something small-ish to do ;)

from valetudo.

stefanct avatar stefanct commented on June 5, 2024

It would already help tremendously if the current (map/real-world) coordinates of the mouse pointer would be displayed in the map view. This should be way easier to implement than the full customization of zones and gotos within the map view.

from valetudo.

stefanct avatar stefanct commented on June 5, 2024

Works well, nice, thank you! Still a bit hidden though ;) Some issues I noticed: resizing the (browser) window wreaks havoc; it would be nice to be able to edit the coordinates. Most intuitively would be of course to drag'n'drop the edges or corners, but I think making the text fields writable and redrawing the red border on new inputs would be good enough.

from valetudo.

Hypfer avatar Hypfer commented on June 5, 2024

Fixed with 0.2.0

from valetudo.

stefanct avatar stefanct commented on June 5, 2024

Including the resize problem?

from valetudo.

matthiasharrer avatar matthiasharrer commented on June 5, 2024

nope .. it did strange things i had not have the time to investigate further unfortunately .. do you resize frequently?

from valetudo.

Hypfer avatar Hypfer commented on June 5, 2024

True

from valetudo.

stefanct avatar stefanct commented on June 5, 2024

The GUI selection stuff is working fine (although tool tips for the buttons on the map and a distinct color for the goto point would be nice). However, I could not find a way to use the features drawn either on /zone or the normal map to form persistent zones/gotos. So this is actually a regression in terms of usability to set up permanent zones because one can no longer retrieve the coordinates either. Great work Matthias though, thank you!

Using the drawing method in the ordinary zone and goto setups is probably the goal isn't it? In that case - unless this is tracked in some other issue - I would not deem this as fixed.
Edit: apparently somewhere else thought a like ;) #102

from valetudo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.