EmbeddedDBusDaemon thread never ends. about dbus-java HOT 4 CLOSED

We have two issues here.
The first is: checking if transport.isConnected() is always false and it is also unnecessary, I can always call close() as long as transport is not null.

The second issue: The thread blocks in a BlockingQueue poll() operation. This blocks indefinite and will only stop if a message is available or if the thread gets an interrupt signal.
When close() is called on DBusDaemon object, the queue poll() operation is not terminated/interrupted - therefore the thread keeps running.
I fixed that as well and using join() in EmbeddedDBusDaemon.close() to ensure thread is terminated when close() returns.

from dbus-java.

Thanks as always. That has fixed the problem in my test environment. Feel free to close this.

As we needed this fixed quickly, I have published builds of 4.3.1-SNAPSHOT again to our company maven repository (https://artifactory.jadaptive.com/ext-snapshots-local if anyone is interested).

It made me think, have you considered publishing SNAPSHOT builds yourself? Being as you are already publishing to central yourself, its very low effort to get them on the "official" snapshot repository at https://oss.sonatype.org/content/repositories/snapshots.

You just add the following and mvn publish as normal. The rules for snapshots are more relaxed too, like i don't think they need to be signed.

<distributionManagement>
    <snapshotRepository>
	<id>ossrh-sshtools</id>
	<url>https://oss.sonatype.org/content/repositories/snapshots</url>
    </snapshotRepository>
    ..
    ..
</distributionManagement>

Edit: Ignore all of that, I see you already have that in the POM. I really should have checked :). I assume then 4.3.1-SNAPSHOT was just never published as a SNAPSHOT

from dbus-java.

Maybe you can provide a proper PR for that?
If snapshots don't need to be signed I can change the github actions to publish new snapshots when I update master branch...

from dbus-java.

oh wow heh. replied at same time.

right ok... so the pom does already have it, then i guess you just need to do the Github thing.

from dbus-java.