Giter VIP home page Giter VIP logo

Comments (3)

hypfvieh avatar hypfvieh commented on July 17, 2024

As you might know, I'm not the original author of the code. I just took it and re-organized, cleaned various java warnings, added generics here and there and created a maven project out of it.

There are only a few things added either by myself or by some other committers (like PropertiesChangedListener).

So because of that, I expect that there are lots of ugly parts and code smells within this library.
I also really dislike the if (EXCEPTION_DEBUG) stuff, but I'm just to busy to cleanup all this mess.

But hey, if you don't like it, fix it and I will happily merge your changes.

from dbus-java.

hypfvieh avatar hypfvieh commented on July 17, 2024

I just merged your changes and I also removed the 'EXCEPTION_DEBUG' flag.

It might be a good idea to review the whole code and clean this exception mess. Exceptions are thrown everywhere, logged and then being wrapped in another exception to be thrown, which in turn will be logged and maybe wrapped in the next method.. This is really bad style.
Also catching RuntimeExceptions does not seem to be a good idea to me.

from dbus-java.

xeruf avatar xeruf commented on July 17, 2024

Yeah a lot of waste lays around when code is untouched for 10 years. I don't know what's up with freedesktop.org, but if they are still active we could try to push this officially to get some traction and hints.

from dbus-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.