DBusConnection timeout about dbus-java HOT 6 CLOSED

No that is not the intended behaviour. I guess that this has something to do with the pull request which added the timeout stuff ..

from dbus-java.

Currently this timeout is used as the read timeout on the connection. Is that really needed? Maybe it makes more sense to have a connect timeout (at least for TCP - don't know if this is useful for domain sockets)?

from dbus-java.

I think setting a read timeout on the InputStream is not really useful at all (weird behaviour).
There might be no answer for a long time, so closing the stream after a minute or so would not be suitable for any usage.

As you said, a connect timeout is useful at least for TCP.

On unix sockets, I cannot imagine any configuration that would benefit from a connect timeout.
If there is a permissioning issue, the connection will fail immediately.
If there is no socket file at all, connection also fails instantly.

If you like you can fix it, then I'll merge your PR tomorrow, otherwise I'll take a look at it tomorrow.

from dbus-java.

I'll leave it for you since since I'm not quite sure what to do with the timeout ;)

from dbus-java.

I've changed the timeout stuff. Timeout will now only be used when using TCP socket and only for the connect method (to set the timeout before connection attempt fails).

All other options do not make sense at all. Stop reading on the InputStream after X seconds is not useful in any way. It would only make sense if DBus would use some sort of heartbeating system, but there isn't something like that.

from dbus-java.

Thanks, works.

from dbus-java.