Giter VIP home page Giter VIP logo

Comments (6)

robertknight avatar robertknight commented on August 16, 2024 1

Hypothesis sets a non-writable property on the sidebar iframe specifically to avoid pywb messing with it. See

return Object.defineProperty(sidebarFrame, 'allow', {
. We could avoid the error here by making the allow property writable, but making the setter a no-op, which is how various native DOM properties work if you assign invalid values to them.

from client.

acelaya avatar acelaya commented on August 16, 2024

I created a PR upstream to avoid the need for any workaround, after agreeing with the maintainer that it made sense, but it has been stale since webrecorder/wombat#134

We could avoid the error here by making the allow property writable, but making the setter a no-op

I think this is very reasonable.

from client.

acelaya avatar acelaya commented on August 16, 2024

The PR in wombat has been merged and released. I suppose we'll get the fix when pywb is updated.

from client.

robertknight avatar robertknight commented on August 16, 2024

I suppose we'll get the fix when pywb is updated.

I'm not sure how long that will take. We should probably put an interim workaround in our own code, such as giving the sidebar iframe a no-op allow setter.

from client.

acelaya avatar acelaya commented on August 16, 2024

I suppose we'll get the fix when pywb is updated.

I'm not sure how long that will take. We should probably put an interim workaround in our own code, such as giving the sidebar iframe a no-op allow setter.

Yep, agree.

from client.

acelaya avatar acelaya commented on August 16, 2024

I created #6227 to address this with a noop setter as suggested.

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.