Comments (6)
Fixed by 7b4c20b
from django-enumfields.
Does not work:
class FooModel(modelsModels):
class Gender(Enum):
MALE = "m"
FEMALE = "f"
UNKNOWN = "u"
class Labels:
MALE = 'Male',
FEMALE = 'Female',
UNKNOWN = 'Unknown'
gender = EnumField(Gender, max_length=1, blank=True, null=True)
python manage.py makemigrations
returns:
File "/home/bhe/.virtualenvs/mx-py34/lib/python3.4/site-packages/django/db/migrations/writer.py", line 349, in serialize
raise ValueError("Cannot serialize: %r\nThere are some values Django cannot serialize into migration files.\nFor more, see https://docs.djangoproject.com/en/dev/topics/migrations/#migration-serializing" % value)
ValueError: Cannot serialize: <Gender.MALE: 'm'>
There are some values Django cannot serialize into migration files.
For more, see https://docs.djangoproject.com/en/dev/topics/migrations/#migration-serializing
from django-enumfields.
I see; I hadn't actually tried migrations (just got it to work with unmigrated models).
I was able to get it working by adding a deconstruct method in the init method like so:
def __init__(self, value):
def deconstruct():
return (
'%s.%s' % (self.__class__.__module__, self.__class__.__name__),
(self.value,),
{}
)
self.deconstruct = deconstruct
A standard deconstruct method fails because Django tries to call it on the type, not just the instances. I think this might be considered a Django bug, so I haven't yet made a pull request here. If I've missed something, I'm open to suggestions.
I would also remove 'choices' in the deconstruct method in EnumFieldMixin
, since it should be generated from the enum:
kwargs.pop('choices', None)
from django-enumfields.
There could occur another issue with nested classes.
class FooModel(models.Model):
class Gender(Enum):
MALE = "m"
FEMALE = "f"
UNKNOWN = "u"
g = EnumFIeld(Gender)
vs.
class Gender(Enum):
MALE = "m"
FEMALE = "f"
UNKNOWN = "u"
class FooModel(models.Model):
g = EnumFIeld(Gender)
Something like (self.__class__.__module__, self.__class__.__name__),
cannot be used with nested classes, I think. Because the Django migration engine cannot import a class from another one.
from django-enumfields.
Related Django bug: https://code.djangoproject.com/ticket/22951
from django-enumfields.
@bh @samh Sorry this went under the radar ):
I just pushed 0.5.1 which removes choices
from the deconstructed kwargs. I think we can get around the nested class issue by improving our handling of the string case and having deconstruct()
always use a string.
from django-enumfields.
Related Issues (20)
- Drop Python2 compatibility HOT 4
- Add blurb about included enumeration types in Django 3.0? HOT 4
- Automatically register EnumFieldListFilter
- faced this while trying to upgrade a django 1.8 project to django 2.2/3.0 HOT 8
- New release on PyPI HOT 2
- Customize enum choices in serializer HOT 2
- 2.1.0 Incompatibility with drf-yasg HOT 2
- DRF : Object of type Gender is not JSON serializable when calling OPTIONS request HOT 1
- Limit choices of an enum HOT 2
- Migrate to new CI platform HOT 5
- Python 3.11 Support HOT 1
- Allow to serialize enum by names HOT 2
- Breaks with django 2.0 HOT 4
- Calculate max_length automatically? HOT 2
- Deprecation warning in Django 2.1.1 HOT 2
- Support Field attributes (like 'name', etc) HOT 1
- Accept subset of the Enum values HOT 2
- Incompatibility with django-filter HOT 1
- Is the project alive? HOT 13
- Includes tests in source tarball
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-enumfields.