New types breaks i18next-chained-backend compatibility about i18next-http-backend HOT 8 CLOSED

Ohh never mind, I just got what's happening, I'll see what I can do

from i18next-http-backend.

Hey @adrai, we have some options:
1 - Implement the augmentation for the i18next-chained-backend plugin, but users would have to import i18next-chained-backend first.

2 - Remove the augmentation from all backend plugins, and it's up to users to manually implement the augmentation.
3 - Alternatively, we can infer based on Backend passed to the init function, but that I'd cause major breaking changes.

Which one should we choose?

from i18next-http-backend.

I have no clue... (I'm not a TypeScript user)
Maybe 1) or if not that much of a major break 3) 🤷‍♂️

from i18next-http-backend.

I think option 1 is good enough. If it is in the documentation then most people would understand it.

Option 3 would be good too but I am not sure if it is worth it to introduce a single braking change just for this. Maybe if there are more in the near future?

from i18next-http-backend.

//cc @pedrodurek

from i18next-http-backend.

Hey @mxsxs2, can you provide an example?

from i18next-http-backend.

i18next/i18next-browser-languageDetector#235 Will more than likely cause the same issue.

from i18next-http-backend.

Hey @adrai, we have some options: 1 - Implement the augmentation for the i18next-chained-backend plugin, but users would have to import i18next-chained-backend first.

2 - Remove the augmentation from all backend plugins, and it's up to users to manually implement the augmentation. 3 - Alternatively, we can infer based on Backend passed to the init function, but that I'd cause major breaking changes.

Which one should we choose?

Can't believe this is the solution 😄

from i18next-http-backend.