Dynamic routes render on any URL about i18next-node HOT 11 CLOSED

you can use https://github.com/i18next/i18next-node/blob/master/lib/i18next.js#L314

in combination with the ensureSupportedLanguage Middleware on line 325

from i18next-node.

This doesn't fix everything I think.

I now added

ensureLngSupport: true

to the configuration.

Basically what it does now is:

/en/team (200) 👍
/en/team/xxx (404) 👍
/ (200) 👍
/xxx (200, should be 404) 👎
/en/ (404, should be 200) 👎

Hope this isn't too hard to understand.

from i18next-node.

i18n.addRoute('/:lng/' will result in /en route not /en/

why /xxx is allowed idk.

from i18next-node.

might need to add some more test cases here: https://github.com/i18next/i18next-node/blob/master/test/i18next.server.spec.js#L40 but on holiday right now...so not sure i get to it right now.

from i18next-node.

Hm. /de and /de/ do render, but in English, not German. Thats why I think that something is buggy because after the / everything is allowed and it renders over the Controller.home.

from i18next-node.

not sure...https://github.com/i18next/i18next-node/blob/master/test/i18next.server.spec.js#L70 tests this and tests are ok...but might be i miss something in the test cases.

from i18next-node.

I tested a bit more, and broke it down to one line:

with

ensureLngSupport: true

the code which is causing this is:

i18n.addRoute('/:lng/', Config.get('languages'), app, 'get', Controllers.home);

This is also true when you use it without the slash at the end

(/:lng)

from i18next-node.

as far i know that's regular behaviour in express. /something/ allows /something. you might try a regex route like /:lng/*

from i18next-node.

Hm. I just also just discovered that you can put anything in /:lng/ ( Like /isaduh/team/ ) and it will also render in English.

from i18next-node.

anything passed to /:lng/ will be taken as param. So some invalid language there will fallback to your fallback language. the /:lng will not be translated or replaced as all params be kept as params for express -> /:lng will be needed to grab the language.

might optimize that after upcoming version v2 of i18next.

from i18next-node.

upcoming v2: http://i18next.github.io/i18next.com/

i18next-node will be replaced by https://github.com/i18next/i18next-express-middleware

PRs welcome

from i18next-node.