Giter VIP home page Giter VIP logo

Comments (8)

bhaskerchari avatar bhaskerchari commented on June 16, 2024

I have made few changes in jquery-i18next.js starting line no: 67 in my local to fix this:

Old Code:
else if (attr === 'prepend') { ele.prepend(i18next.t(key, extendDefault(opts, ele.html()))); }

New Code:

else if (attr === 'prepend') { if (ele.find("#" + key).length > 0) { ele.find("#" + key).html(i18next.t(key, extendDefault(opts, ele.html()))); } else { ele.prepend("<span id=" + key.split(" ").join("") + ">" + i18next.t(key, extendDefault(opts, ele.html())) + "</span>"); } }

Can you please suggest if this is a valid fix or do you have any other proper fix or suggestions?

Thanks,
Bhasker

from jquery-i18next.

jamuhl avatar jamuhl commented on June 16, 2024

seems valid. If you like you can provide a PR changing both prepend and append.

from jquery-i18next.

bhaskerchari avatar bhaskerchari commented on June 16, 2024

Hi @jamuhl ,

Sorry I cannot raise a PR as I don't have access to git installed on my pc at office due to securoty reasons and even I cannot clone git repo due to network proxy.

May be you can please go ahead and make the necessary changes as suggested for prepend and append attributes. Hope it is fine.

Thanks,
Bhasker

from jquery-i18next.

jamuhl avatar jamuhl commented on June 16, 2024

published [email protected]

from jquery-i18next.

bhaskerchari avatar bhaskerchari commented on June 16, 2024

cool thanks 👍

from jquery-i18next.

bhaskerchari avatar bhaskerchari commented on June 16, 2024

Hi @jamuhl,

There seems to be a small glitch in the fix as I am not trimming the spaces in the key when I am actually trying to find the element but I did so when I am actually assigning the id which could cause the problem.

PF link of screenshot for the changes required for the same and I am also adding the code changes below for the full function parse starting line no: 43.

function parse(ele, key, opts) {
            if (key.length === 0) return;

            var attr = 'text';
            // Removing any spaces in key for valid id
            var trimmedKey = key.split(' ').join('');

            if (key.indexOf('[') === 0) {
                var parts = key.split(']');
                key = parts[1];
                attr = parts[0].substr(1, parts[0].length - 1);
            }

            if (key.indexOf(';') === key.length - 1) {
                key = key.substr(0, key.length - 2);
            }

            function extendDefault(o, val) {
                if (!options.parseDefaultValueFromContent) return o;
                return babelHelpers.extends({}, o, { defaultValue: val });
            }

            if (attr === 'html') {
                ele.html(i18next.t(key, extendDefault(opts, ele.html())));
            } else if (attr === 'text') {
                ele.text(i18next.t(key, extendDefault(opts, ele.text())));
            } else if (attr === 'prepend') {
                if (ele.find('#' + trimmedKey).length > 0) {
                    ele.find('#' + trimmedKey).html(i18next.t(key, extendDefault(opts, ele.html())));
                } else {
                    ele.prepend('<span id=' + trimmedKey + '>' + i18next.t(key, extendDefault(opts, ele.html())) + '</span>');
                }
            } else if (attr === 'append') {
                if (ele.find('#' + trimmedKey).length > 0) {
                    ele.find('#' + trimmedKey).html(i18next.t(key, extendDefault(opts, ele.html())));
                } else {
                    ele.append('<span id=' + trimmedKey + '>' + i18next.t(key, extendDefault(opts, ele.html())) + '</span>');
                }
            } else if (attr.indexOf('data-') === 0) {
                var dataAttr = attr.substr('data-'.length);
                var translated = i18next.t(key, extendDefault(opts, ele.data(dataAttr)));

                // we change into the data cache
                ele.data(dataAttr, translated);
                // we change into the dom
                ele.attr(attr, translated);
            } else {
                ele.attr(attr, i18next.t(key, extendDefault(opts, ele.attr(attr))));
            }
        }

May be you can move this fix once you publish the next version.

Thanks,
Bhasker

from jquery-i18next.

jamuhl avatar jamuhl commented on June 16, 2024

published [email protected]

from jquery-i18next.

bhaskerchari avatar bhaskerchari commented on June 16, 2024

Hi @jamuhl ,

The fix for that issue was to use the below lines of code:

Actually I found the issue the day after I posted the fix for this issue but was busy to post the fix here.

Please update the lines of code in jquery-i18next.js with below 2 lines of code(line no's : 47 and 48):

// Removing any spaces and any invalid special characters in key for valid html5 id

var trimmedKey = key.replace(/[^a-z0-9-_:.]|^[^a-z]+/gi, "");

Thanks,
Bhasker

from jquery-i18next.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.