Rust 2021 edition is a major, not a "patch" change about data-encoding HOT 6 CLOSED

Thanks for bringing this issue to my attention! I wasn't aware that it would break the build for old compilers. I'll take a look at it this weekend to see how to address the issue (revert, document, or something else).

from data-encoding.

I would prefer revert, because https://github.com/deltachat/deltachat-core-rust tries to support Rust >=1.51 (this version introduced const generics which are required by rustcrypto crates) and depends on data-encoding via some crates, including mailparse soon.

Also since you have a CI setup, it makes sense to fix some MSRV and automatically test that the crate can still be built with it. If some change breaks compatibility you will notice it and can decide whether it's worth rising the minimum version.

from data-encoding.

Indeed, reverting sounds like the best approach for now, but I'd like to check if there are alternatives before committing. For sure, the priority is to not break users.

Thanks for the CI idea, I'll definitely do that.

from data-encoding.

It looks like there are no clear guidelines on how an MSRV bump should impact the crate version. The Rust Embedded WG only restricts to the latest stable.

Given that the data-encoding library is stable, I'll take the most conservative approach and only bump the MSRV when needed. I'll also do the same for the unstable macro libraries for now, but might revisit this in the future. The binary is out of scope since it cannot break a user build. Similarly, non-exported crates are out of scope.

The smallest MSRV is currently 1.46.0 according to cargo-msrv. The MSRV is documented in the package.rust-version field of each library and is checked in continuous integration.

If this sounds good to you, I'll submit #54.

Thanks again for bringing this issue to my attention before it was too late!

from data-encoding.

Checked #54, looks good.

from data-encoding.

Thanks! Merging.

from data-encoding.