Giter VIP home page Giter VIP logo

Comments (4)

danielhuppmann avatar danielhuppmann commented on June 21, 2024 1

Well, I'd rather follow the pyam filter() signature

class CodeList:

    def filter(self, **kwargs) -> CodeList:
        keep = np.ones(len(self), dtype=bool)
        for attribute, value in kwargs:
            keep = np.logical_and(keep, [code.attribute == value for code in self])
            # return a new CodeList(keep)

This would also be compatible with the existing signature (if a user wrote filter(hierarchy="common"), not filter("common")).

from nomenclature.

phackstock avatar phackstock commented on June 21, 2024

I guess the interface for this would look something like this then:

class CodeList:

    def filter(self, attribute, value) -> CodeList:
        matched = [code.attribute == value for code in self]
        # return a new CodeList(matched)

The above example wouldn't work exactly like this but is this what you had in mind @danielhuppmann?

from nomenclature.

phackstock avatar phackstock commented on June 21, 2024

Ok, good point, that is cleaner and more powerful.

from nomenclature.

phackstock avatar phackstock commented on June 21, 2024

Closing as this was addressed by #236

from nomenclature.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.