Add file name to errors in RegionAggregationMapping about nomenclature HOT 4 CLOSED

Sounds like a good strategy, thanks!

from nomenclature.

The validation is happening as part of an iteration over all file names anyway, so why not catch the error that happens in the parsing of a particular file, add the message "The following occurred in file {file}: {error.message}", then raise the error again?

from nomenclature.

Good point, but I don't think that it's the cleanest way to intercept our own errors and then pop something on. Simply saving the file name does not cost that much memory.
Additionally, there is a use case where having the file name inside the RegionAggregationMapping is rather useful. When checking if there are any model collisions for the given region mappings. Let's say we have two mappings both for model_a, we only realize the error once we are reading the second file that defines a mapping for model_a. However, I would argue its important for the user to know both conflicting files. If we have it saved inside the RegionAggregationMapping that piece of information is easy to come by.

from nomenclature.

Perfect, I'll open a PR as soon as I have something

from nomenclature.