Comments (6)
Agreed, I pushed a change that should fix this. Thanks for raising the issue. Will publish in next version.
from react-string-replace.
My solution - https://github.com/iansinnott/react-string-replace/pull/75
@iansinnott, please check it.
from react-string-replace.
Have the same issue with next Regex: /({phone})|({name})/gi
Then var result = str.split(re);
- provides next result: ['Please enter the code we sent to you at⨠', '{phone}', undefined, '', undefined, '{name}', '. ']
The solution for this can be next fix: var result = str.split(re).filter(Boolean);
@iansinnott Can you fix this one?
from react-string-replace.
what's the str
value?
from react-string-replace.
I think your regex is not doing what you expect. try using only one matching group with |
to separate alternative matches.
Use https://regex101.com/ for quick iteration testing regex
from react-string-replace.
@iansinnott Thanks for remark. You are right, there was an issue with our regex
however, IMO, in order to prevent error throws, better to add the solution above(or in existed PR), or to add try catch to the code(maybe return error with 'wrong regex provided' or something similar)
from react-string-replace.
Related Issues (20)
- Works with splitted element HOT 1
- Typescript definitions are wrong (I think) HOT 1
- Is there any way to run the replace on only the first match? HOT 3
- Match is blank? HOT 2
- ES6 Module declaration HOT 1
- Multiple replacements in a string are not working properly HOT 2
- [object Object] Gets returned from the reactStringReplace() function HOT 3
- Not properly finds substrings if they are consecutive or at the end of the phrase HOT 2
- Capture groups? HOT 4
- Natural index numbers on callback function HOT 2
- Remove lodash HOT 4
- Publish v0.5.0 to NPM HOT 2
- It doesn't work with input fields! - What should I do? [Update: it does!] HOT 3
- Boundary condition checks and arguments check is missing
- ReactNodeArray is deprecated HOT 2
- I have a problem with '/r' in text. It not working '/r' HOT 1
- React.ReactNodeArray is deprecated HOT 2
- Certain regex doesn't seem to work
- Encountered undefined value during string replacement and weird behaviour
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-string-replace.