Giter VIP home page Giter VIP logo

Comments (8)

barlock avatar barlock commented on August 19, 2024

ref #15

I've realized that bower pulls from git. Is there a way you can config bower to use a different branch where we can put the dist folder, or do we have to automatically check the dist folder back into master?

from colors.

barlock avatar barlock commented on August 19, 2024

@seejamescode Why did you close this? This is still quite valuable as it generates the .scss and the .json outputs from a single input rather than forcing someone to touch two places in order to make a change. Any time we can remove human error from coding, the better.

from colors.

barlock avatar barlock commented on August 19, 2024

If you don't agree with the method of generation, you should remove the src notion from this project and the related gulp tasks.

from colors.

seejamescode avatar seejamescode commented on August 19, 2024

The description was not clear for me then. Currently, the source/ code is edited and outputs into the root. Are you suggesting we have the files generated into a dist/ folder also?

from colors.

barlock avatar barlock commented on August 19, 2024

I think the code outputs to a dist folder https://github.com/IBM-Design/colors/blob/master/gulpfile.js#L15. I'm suggesting that the dist folder not be checked in and generated at release time

from colors.

seejamescode avatar seejamescode commented on August 19, 2024

I gotcha now! I was confused when my example project did not have a manual dist folder.

Do you think the dist folder is right place for output files? I feel like the root would be easier for non-developers.

from colors.

seejamescode avatar seejamescode commented on August 19, 2024

Now that I have poked around a bit: I would lean towards using a dist folder, but removing the gitignore for the folder. It would beneficial for all file types to be accessible directly from the repo. I am reflecting that in PR #24. Thoughts?

from colors.

seejamescode avatar seejamescode commented on August 19, 2024

We can keep this discussion going in #26, but I believe the breaking change point and also keeping it non-dev friendly are good reasons to keep built files in the root.

from colors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.