Comments (8)
ref #15
I've realized that bower pulls from git. Is there a way you can config bower to use a different branch where we can put the dist folder, or do we have to automatically check the dist folder back into master?
from colors.
@seejamescode Why did you close this? This is still quite valuable as it generates the .scss and the .json outputs from a single input rather than forcing someone to touch two places in order to make a change. Any time we can remove human error from coding, the better.
from colors.
If you don't agree with the method of generation, you should remove the src
notion from this project and the related gulp tasks.
from colors.
The description was not clear for me then. Currently, the source/ code is edited and outputs into the root. Are you suggesting we have the files generated into a dist/ folder also?
from colors.
I think the code outputs to a dist folder https://github.com/IBM-Design/colors/blob/master/gulpfile.js#L15. I'm suggesting that the dist folder not be checked in and generated at release time
from colors.
I gotcha now! I was confused when my example project did not have a manual dist folder.
Do you think the dist folder is right place for output files? I feel like the root would be easier for non-developers.
from colors.
Now that I have poked around a bit: I would lean towards using a dist folder, but removing the gitignore for the folder. It would beneficial for all file types to be accessible directly from the repo. I am reflecting that in PR #24. Thoughts?
from colors.
We can keep this discussion going in #26, but I believe the breaking change point and also keeping it non-dev friendly are good reasons to keep built files in the root.
from colors.
Related Issues (20)
- Orange vs Peach HOT 1
- White needs a light gray stroke around it HOT 2
- Maybe a border around the white? HOT 1
- Color contrast for warmer colors HOT 2
- differentiating between colors HOT 3
- Ability to compare colors
- Different hue values in cool grays HOT 2
- Publish new version, 2.0.3, to npm HOT 1
- Examples on color page don't match new colors HOT 2
- Getting color throws an error if no grade is specified HOT 1
- Update whites grades documentation
- Remove Eyeglass version warning HOT 2
- Color Blind safe Orange 40 does not match result of color("orange", 40) HOT 1
- Throwed wrong error of undefined HOT 1
- $Palette variable doesn't match supplied value throwing errors. HOT 1
- Filename versioning HOT 1
- Install options question HOT 1
- URL in description links to a 404 HOT 1
- name collision with PostCSS HOT 1
- Links in readme are dead
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from colors.