Customer reported the following issue today with an impact build. Us

ImpactBuild not recognizing certain excludeFileList patterns about dbb-zappbuild HOT 3 CLOSED

ibm commented on August 13, 2024

ImpactBuild not recognizing certain excludeFileList patterns

from dbb-zappbuild.

Comments (3)

dennis-behm commented on August 13, 2024

Hi Nelson, I build a scenario and tried to reproduce your issue with the dbb-zappbuild from this repository. But I failed. The config files always got excluded - on fullBuild and also on impactBuild.

Are you sure, that you are pointing to the right application-conf/application.properties? Can you probably share the entire log?

from dbb-zappbuild.

dennis-behm commented on August 13, 2024

I did a further investigation into this.

There is a scenario,

when the user already performed builds and built-up the collection,
then adds files to the exclude list,
In this scenario, the impactResolver will returns references from the dbb webbapp / collection.

In the ImpactUtilites, these matches are not verified against the exclude file list; this happens in this part of the code:

dbb-zappbuild/utilities/ImpactUtilities.groovy

Lines 66 to 74 in c667277

 def impacts = impactResolver.resolve() 

 impacts.each { impact -> 

 def impactFile = impact.getFile() 

 if (props.verbose) println "** Found impacted file $impactFile" 

 // only add impacted files that have a build script mapped to it 

 if (ScriptMappings.getScriptName(impactFile)) { 

 buildSet.add(impactFile) 

 if (props.verbose) println "** $impactFile is impacted by changed file $changedFile. Adding to build list." 

 }

It think it is valid, to check the exclude list also for the found impacted programs.

However, in this scenario, the collection should even not carry these dependencies.

@drbruce-git, what is your view on it?

from dbb-zappbuild.

nlopez1-ibm commented on August 13, 2024

Workaround tip provided by Nicolas, rescan the collection with the exclude of the CFG file to prevent the impact issue.

from dbb-zappbuild.

Recommend Projects

ImpactBuild not recognizing certain excludeFileList patterns about dbb-zappbuild HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	def impacts = impactResolver.resolve()
	impacts.each { impact ->
	def impactFile = impact.getFile()
	if (props.verbose) println "** Found impacted file $impactFile"
	// only add impacted files that have a build script mapped to it
	if (ScriptMappings.getScriptName(impactFile)) {
	buildSet.add(impactFile)
	if (props.verbose) println "** $impactFile is impacted by changed file $changedFile. Adding to build list."
	}