New react-router typings causes mismatch with mobx-react-router about mobx-react-router HOT 3 CLOSED

Hey thanks for the issue (and for the great detail) - good find.

My first question is: what is the case for passing the history property from a RouterStore instance in to a Router component, as opposed to just passing the return history value from syncHistoryWithStore as the README example does? i.e:

const browserHistory = createBrowserHistory();
const routingStore = new RouterStore();

const stores = {
  // Key can be whatever you want
  routing: routingStore,
  // ...other stores
};

const history = syncHistoryWithStore(browserHistory, routingStore);

ReactDOM.render(
  <Provider {...stores}>
    <Router history={history}>
      <App />
    </Router>
  </Provider>,
  document.getElementById('root')
);

Maybe I'm missing a use case.

But in general I think your current workaround is the correct implementation anyway - meaning the history and location properties should be required in the typings:

export class RouterStore {
  history: History;
  location: Location;
}

Would this solve the problem?

Even though technically those properties can be undefined/null, using this library as described in the docs would mean that any useful application of using the a RouterStore would be in situation where the history and location properties have been set (at any point after the syncHistoryWithStore function call).

from mobx-react-router.

Well, I had just posted the issue when I realized that the "correct" way is to use the history returned from syncHistoryWithStore, so I guess there is no use case for it.

But anyway, I agree with you that we should probably just change the typings to be required no matter what. That would fix the issue (would also mean we wouldn't have to check for undefined everywhere, yay!)

from mobx-react-router.

Added in release 4.0.3

https://github.com/alisd23/mobx-react-router/releases/tag/v4.0.3

from mobx-react-router.