Proposal to conform to new N-API interface about nodejs-idb-connector HOT 6 CLOSED

Original comment by Jesse G (Bitbucket: ThePrez, GitHub: ThePrez).

I believe this to be resolved with the latest commits. Thanks!!

from nodejs-idb-connector.

Ran it through the conversion tool the output is located:
https://bitbucket.org/abmusse/nodejs-idb-connector

Have not built it yet, but getting to it soon.

from nodejs-idb-connector.

Original comment by Jesse G (Bitbucket: ThePrez, GitHub: ThePrez).

Created branch N-API-compliance to serve as a home for this major rework

from nodejs-idb-connector.

Original comment by Liam Allan (Bitbucket: WorksOfLiam, GitHub: WorksOfLiam).

Hi

Sorry for the late reply. If I can find the time I will happily make a PR, until then I will post some notes about what I might do in case anyone else wants to give it a shot.

1. Build nodejs-idb-connector on IBM i with Node.js 8.6.0 or above
2. Once built, attempt to use converter.js which is found in the node-addon-api repository on GitHub.
3. I hear that this will convert around 80% (don't quote me on that) and then it's manual work from there.

Hopefully this is a step in the right direction.

Cheers,
Liam

from nodejs-idb-connector.

Original comment by Jesse G (Bitbucket: ThePrez, GitHub: ThePrez).

https://github.com/nodejs/node-addon-api/blob/master/tools/conversion.js

This conversion tool is a good place to start on the project. It's expected to get about 80% of the conversion done (and they will take issues for anything that reasonably should have been converted and wasn't)

This article may also be useful: https://medium.com/the-node-js-collection/n-api-next-generation-node-js-apis-for-native-modules-169af5235b06

from nodejs-idb-connector.

Original comment by Xu Meng (Bitbucket: mengxumx, GitHub: dmabupt).

Issue #9 was marked as a duplicate of this issue.

from nodejs-idb-connector.