Giter VIP home page Giter VIP logo

Comments (7)

pshipton avatar pshipton commented on June 30, 2024

@JasonFengJ9 Issues should be created in the OpenJ9 repo for proper tracking. That is where the PR build code is as well.

Looking at a grinder, the parameters for test are JDK_REPO and JDK_BRANCH. At the top level job (https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK11_aarch64_linux/1475/console) we see
09:39:38 Using OPENJDK_REPO = https://github.com/ibmruntimes/openj9-openjdk-jdk11.git OPENJDK_BRANCH = openj9 OPENJDK_SHA = b33416dc888ee757c6761810bf416f37c6b17e8a
In the test job (https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_Personal/20/consoleFull), there is no mention of these parameters.

from openj9-openjdk-jdk.

AdamBrousseau avatar AdamBrousseau commented on June 30, 2024

So the ask is that any PR build that changes code in extensions, should pass JDK_REPO & JDK_BRANCH to the test jobs. Correct? I'm not sure I was thinking of the same known issue originally.
Does the test code have ability at the moment to fetch PR refs and checkout a merge ref of extensions repos @llxia?

from openj9-openjdk-jdk.

JasonFengJ9 avatar JasonFengJ9 commented on June 30, 2024

I think the original issue was

from openj9-openjdk-jdk.

pshipton avatar pshipton commented on June 30, 2024

Again, that's in the wrong repo. Pls open an issue at https://github.com/eclipse-openj9/openj9/issues

from openj9-openjdk-jdk.

JasonFengJ9 avatar JasonFengJ9 commented on June 30, 2024

#506 (comment)

It was tracked at infrastructure/issues/7363 unless an openj9 issue helps.

from openj9-openjdk-jdk.

pshipton avatar pshipton commented on June 30, 2024

Everything here is open source, the code that needs to be changed is open source in the OpenJ9 repo.

from openj9-openjdk-jdk.

JasonFengJ9 avatar JasonFengJ9 commented on June 30, 2024

Created

from openj9-openjdk-jdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.