Giter VIP home page Giter VIP logo

Comments (6)

shoepfl avatar shoepfl commented on July 27, 2024 1

Okay thanks for the help - maybe that needs more clairification in the PEtab documentation as the description for the bounds state there:
"Must be provided in linear space, independent of parameterScale."

from this at least it is confusing when I have to give the bounds in linear scale explicitly but indeed the log of them are taken as boundaries. But thats probably a topic for the PEtab implementation so I will shift the discussion to there.

Thanks for your help!

from pypesto.

dilpath avatar dilpath commented on July 27, 2024

What result do you expect, and what result do you see? pyPESTO returns parameters on parameter scale, which is log according to your PEtab parameters table. If you unscale the parameters, are they as expected?

from pypesto.

dilpath avatar dilpath commented on July 27, 2024

The parameters plot can be used as a diagnostic here to visualize parameter values and their optimization bounds, on parameter scale.

e.g. see usage of visualize.parameters in https://github.com/ICB-DCM/pyPESTO/blob/main/doc/example/rosenbrock.ipynb

from pypesto.

shoepfl avatar shoepfl commented on July 27, 2024

Sorry i forgot to add the estimated parameter vector, the problem is that the unscaled parameters are outside the bounds we defined.

For example for LI__ICGLI2BI_Vmax, which should have a lower bound of 1e-05 and a upper bound of 10.0 according to the parameter table, however the actual value is much lower. I attached the visualization as you suggested, there it is also visible that the lower bound is 1e-12.
icg_sd_parameter_visualization

from pypesto.

dilpath avatar dilpath commented on July 27, 2024

Ah, the lower bound for LI__ICGLI2BI_Vmax in the plot is close to -12 on log-scale, which is the lower bound 1e-5 on log-scale (i.e. log(1e-5) = -11.5), which appears to be the lower bound for in your plot. To get the values on linear scale, you would need to unscale, e.g.:

import petab
petab_problem = petab.Problem.from_yaml(yaml_file)
unscaled_optimum = petab_problem.unscale_parameters(dict(zip(
    pypesto_problem.x_names,
    result.optimize_result.list[0].x,
))

from pypesto.

yannikschaelte avatar yannikschaelte commented on July 27, 2024

Closing here as this concerns the petab documentation

from pypesto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.