Giter VIP home page Giter VIP logo

Comments (15)

herrbischoff avatar herrbischoff commented on May 22, 2024

Just in case you're interested, I have created a very simple type logo with Apple's new San Francisco display font. I will send a pull request in a minute.

from awesome-macos.

iCHAIT avatar iCHAIT commented on May 22, 2024

Merged the PR but looks like the label is broken.

from awesome-macos.

herrbischoff avatar herrbischoff commented on May 22, 2024

This is weird, because you use the same kind of link for oss.png, which works.

https://github.com/iCHAIT/awesome-osx/blob/master/media/oss.png

vs.

https://github.com/iCHAIT/awesome-osx/blob/master/media/awesome.svg

Since the Awesome spectacles are SVG as well, it also cannot be an embedding problem.

from awesome-macos.

iCHAIT avatar iCHAIT commented on May 22, 2024

Yes, indeed I also tried using the img tag instead and it still doesn't works :/

from awesome-macos.

herrbischoff avatar herrbischoff commented on May 22, 2024

But opening the direct link previews the file correctly. What the...?

from awesome-macos.

iCHAIT avatar iCHAIT commented on May 22, 2024

Looks like it has something to so with SVG's, maybe.

from awesome-macos.

herrbischoff avatar herrbischoff commented on May 22, 2024

It shouldn't:

screen shot 2015-09-18 at 14 51 00

from awesome-macos.

herrbischoff avatar herrbischoff commented on May 22, 2024

But just for the sake of it, here's the same file exported as a PNG at 3x:

awesome

(Hopefully GitHub won't butcher it...)

from awesome-macos.

iCHAIT avatar iCHAIT commented on May 22, 2024

Serving the image via rawgit makes it visible on the readme :/
It is a poor workaround though.

from awesome-macos.

herrbischoff avatar herrbischoff commented on May 22, 2024

So it won't even work with the PNG I uploaded above?

from awesome-macos.

iCHAIT avatar iCHAIT commented on May 22, 2024

I am not sure, after a little bit of googling I found this -

http://stackoverflow.com/a/21521184

Though I don't know how relevant is this now.

from awesome-macos.

herrbischoff avatar herrbischoff commented on May 22, 2024

I see. Good catch! So it appears to be a GitHub issue. If you want, I will open another pull request, removing the SVG and adding the PNG.

from awesome-macos.

iCHAIT avatar iCHAIT commented on May 22, 2024

I don't think their is really a need for it. Totally fine with SVG.

Though in case you wanted to dig a little deeper into the issue -

isaacs/github#316

from awesome-macos.

herrbischoff avatar herrbischoff commented on May 22, 2024

Interesting, thanks for the link! I will keep that in mind for future occasions.

from awesome-macos.

iCHAIT avatar iCHAIT commented on May 22, 2024

👍

from awesome-macos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.