Giter VIP home page Giter VIP logo

Comments (4)

Speiger avatar Speiger commented on July 28, 2024 1

But before we close this I want to make sure that the issue is "because of that"

from firstaid.

ichttt avatar ichttt commented on July 28, 2024

The reason I use LivingHurtEvent instead of LivingDamageEvent is that I do custom armor calculations (as first aid only takes the armor of the specific limb into account). I also post a LivingDamage event when I did my armor/enchantment calculations:

damage = ForgeHooks.onLivingDamage(player, source, damage); //we post every time we damage a part, make it so other mods can modify

This will not contain the damage value you may expect from the vanilla pipeline, but it is the one used in firstaid for damaging the limb.
I still have to investigate #53, I'm not sure what is causing this

from firstaid.

Speiger avatar Speiger commented on July 28, 2024

Yeah this one is my mistake.
We compare the damage against the existing health while first aid splits that up so our logic does never trigger.

from firstaid.

Speiger avatar Speiger commented on July 28, 2024

Fixed on our side we use your event.

from firstaid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.