Giter VIP home page Giter VIP logo

Comments (7)

LubosKat avatar LubosKat commented on July 17, 2024

Dobra pripomienka. Urcite zapracujeme

from id-sk-frontend.

frkosk avatar frkosk commented on July 17, 2024

keď už sa kutrem v hlavičke, tak tu je neuzavretý span

id-sk-frontend/src/idsk/components/header-extended/template.njk

Lines 128 to 135 in 8e38fab

<span>
<a href="{{ subItem.link }}" title="{{ subItem.text }}">
{% if subItem.icon %}
<i class="{{ subItem.icon }}" aria-hidden="true"></i>
{% endif %}
{{ subItem.text }}
</a>
<span>

from id-sk-frontend.

frkosk avatar frkosk commented on July 17, 2024

A ešte farby by mali byť definové takto aby som si napríklad pre MSSR vedel dať menu fialové vo svojom SCSS a nemusel šahať do IDSK. Celkovo to platí pre componenty.

  $idsk-header-dark-blue: govuk-colour("dark-blue") !default;
  $idsk-header-light-blue: govuk-colour("blue") !default;
  $idsk-header-link: govuk-colour("white") !defaul;

id-sk-frontend/src/idsk/components/header-extended/_header-extended.scss

Lines 11 to 13 in 8e38fab

$idsk-header-dark-blue: govuk-colour("dark-blue");
$idsk-header-light-blue: govuk-colour("blue");
$idsk-header-link: govuk-colour("white");

from id-sk-frontend.

frkosk avatar frkosk commented on July 17, 2024

Sticky hlavičke chýba z-index.

Screenshot 2021-02-10 at 17 23 29

from id-sk-frontend.

LubosKat avatar LubosKat commented on July 17, 2024

v najblizsom release budu pripomienky zahrnute

from id-sk-frontend.

frkosk avatar frkosk commented on July 17, 2024

keď už sa kutrem v hlavičke, tak tu je neuzavretý span

id-sk-frontend/src/idsk/components/header-extended/template.njk

Lines 128 to 135 in 8e38fab

<span>
<a href="{{ subItem.link }}" title="{{ subItem.text }}">
{% if subItem.icon %}
<i class="{{ subItem.icon }}" aria-hidden="true"></i>
{% endif %}
{{ subItem.text }}
</a>
<span>

@LubosKat keď tak pozerám na ten span. Je tam potrebný? lebo keď ho vyhodím nič sa nedeje.

from id-sk-frontend.

robertsopko avatar robertsopko commented on July 17, 2024

Bolo fixnute vo verzii 2.10.0

from id-sk-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.