Nested routes - Incompatibility with Feathers 3.x about feathers-hooks-rediscache HOT 5 CLOSED

Hello @oppodeldoc,
Thank you for the report. I did not migrate yet my code to 3.x.x I will do that ASAP (this afternoon or tomorrow as I have a few meetings to attend :( ).

I have checked the feathers documentation and the process should not be too difficult. It seems that the problem you have encountered is the only one. I will also need to check the tests as I am mocking the params object, and it is obviously different now.

I am not really in favour to have a conditional for the params and then carry on legacy code. I would prefer to use npm versions e.g. version 0.x.x is compatible with feathers 2.x.x and version 1.x.x with version 3. Or maybe bump the plugin version to 3.x.x right away?

Do you see any reason why we should do a conditional?
I will be very happy to review your PR. Thank you for the help!

Sam

from feathers-hooks-rediscache.

I have migrated. The change you propose is fine. You can do a PR with it and could you modify the tests? That is quite easy, there are two test to modify, the both have nested route in the description. I guess we could add a test in the "before" test as well... I can do it. If you are not sure let me know I will do them.

Sam

from feathers-hooks-rediscache.

Thanks @idealley! You're right about versioning and not worrying about backwards-compatibility, I just wasn't sure if you wanted to maintain it, but that's great. I'll submit a PR today!

from feathers-hooks-rediscache.

Ok! @idealley I submitted my PR, it includes the updated tests, I didn't add a before test, though.

One thing I forgot was to add a note in the README about breaking changes. I'm assuming you'll bump this as a major release in versioning, might be nice to put a note in the README as well. Let me know when the latest is on NPM, and thanks again for being so responsive and helpful!

from feathers-hooks-rediscache.

Thank you for your help. I have merged everything.

Sam

from feathers-hooks-rediscache.