Giter VIP home page Giter VIP logo

Comments (1)

CodyReichert avatar CodyReichert commented on September 25, 2024

Alright we got some feedback with just a couple of things to fix and clarify in the readme.txt. Paraphrased here:


Please sanitize, escape, and validate your POST calls

When you include POST/GET/REQUEST/FILE calls in your plugin, it's important to sanitize, validate, and escape them. The goal here is to prevent a user from accidentally sending trash data through the system, as well as protecting them from potential security issues. Some examples from your plugin:

        $value_ = $_POST[$tag->name];
        $value = trim($value_);

In function cf7_identibyte_make_check that gets set here:

$url = "https://identibyte.com/check/" . $data . $api_token;

At the very lease you should slap an esc_url() around that.

Calling images remotely

Offloading images to your own server is disallowed. Please include all images needed for your plugin locally.

Example: src="https://identibyte.com/static/img/logo-120x120.png"

Undocumented use of a 3rd Party or external service

You call https://identibyte.com

While this is actually okay, you neglected to fully document this in your readme. You must update your readme to do the following:

  • clearly explain that your plugin is relying on a 3rd party as a service and under what circumstances
  • provide a link to the service
  • provide a link to the services’ a terms of use and/or privacy policies

from identibyte-for-contact-form-7.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.