fetch_historical_prices_by_epic_and_num_points exception during exception handling about trading-ig HOT 5 CLOSED

I get this error too when I run the test_ig_service function.

A cursory check shows that

IG returns a key called snapshotTime but not snapshotTimeUTC. Changing the expected key to snapshotTime (rest.py:line757) seems to solve the basic issue but then datetime doesn't seem to recognise the date format at (rest.py: line 758).

So it seems IG changed something since this piece of code was written...

I'll dig a little deeper later and see if I can fix it. It seems relatively simple.... (watch me eat my words!)

from trading-ig.

OK here's a fix:

line 757: df = df.set_index('snapshotTime')
line 758: df.index = pd.to_datetime(df.index, format="%Y:%m:%d-%H:%M:%S")

Be aware that the time index will be local time (timezone of the account) and not UTC. As part of the config we could require a timezone to use. But I'll leave that for another iteration.

from trading-ig.

@femtotrader Can you give me rights to open a pull request.

from trading-ig.

You don't need any rights to open a PR.

You just need to first fork this repository.

Clone your fork.

$ git clone https://github.com/YOU/REPOS

Define this repository as upstream.

$ git remote add upstream https://github.com/ORIGINAL_USER/REPOS

Create a branch

$ git checkout -b fix_issue_33

Modify code to fix issue (or add enhancement)

Commit your changes

$ git commit

Push to your repository

$ git push

Open a Pull request (from your repository)
https://help.github.com/articles/creating-a-pull-request/
https://help.github.com/articles/about-pull-requests/

from trading-ig.

Thanks @M1ntcraft3r and @redbullpeter

from trading-ig.