Comments (7)
You might have a look at
Lightstreamer/Lightstreamer-example-StockList-client-python#1
I still don't understand relationship and differences between https://github.com/dw/py-lightstreamer and https://github.com/Lightstreamer/Lightstreamer-example-StockList-client-python
Pinging @dw and @gfinocchiaro
Having a real Python package would help to tackle the problem you are raising
Kind regards
from trading-ig.
Hi, thanks for bringing this to my attention. It seems the lightstreamer.py in this repository, carrying Lightstreamer Srl's copyright, has a great deal in common with my py-lightstreamer code, despite not carrying the original copyright, in violation of the license. Many of the constants, class names, and e.g. the implementation of _decode_field look almost identical.
Will dig into this at some later time when I'm not so busy
from trading-ig.
Hi,
Initially, I have been certainly inspired by the excellent @dw's work but actually, the two implementations are very different, as you can see by comparing the source code.
Yes, _decode_field
is very similar to _decode
, but the logic here is so trivial and also driven by the protocol specifications. And yes, few constant names and only one class name (LSClient
) are almost identical.
By the way, I'm willing to change such names and everything he might believe could violate his original source code. Ask @dw to contact me privately to shed some light on this issue.
We are planning to make the demo as a Python package in the short term.
from trading-ig.
If I can accidentally spot code derived from something I haven't touched for over 5 years, then it should almost certainly still bear the original copyright. The attribution wasn't even directly to me, it's to "the py-lightstreamer authors", which should be trivial to restore. I'm not going to through the files statement-for-statement (an issue like this isn't worth that), but just to say the feeling of familiarity had already started with the blocks of imports at the top of the file!
from trading-ig.
It looks like that the two blocks of imports are quite different. Anyway, as already anticipated, we are going to publish a brand new Python package, with new source code from scratch. Obviously, even the mentioned demo project will be updated as well.
from trading-ig.
Nice to know that a real package on which we could rely will be released. I think that ig-python developers and users will be very pleased to be informed when it will be available.
from trading-ig.
Closing old issue, no activity for more than 2 years
from trading-ig.
Related Issues (20)
- conditional-set-value error when trying to add a SL distance when opening new position HOT 1
- Retrieve how much of working order has been filled if order is partially fulfilled
- Unable to get OPU via streaming API
- Deal Id confirmed but no opend position HOT 1
- lighstreamer error in Docker container - EOFError: EOF when reading a line HOT 1
- fetch_historical_prices_by_epic_and_date_range : "puredeal:err:(none):403 Access forbidden!" HOT 2
- lightstreamer.py -- connect systemd.daemon not available, no watchdog notifications will be sent. HOT 2
- Communication Error / ConnectionResetError: [Errno 104] Connection reset by peer HOT 1
- Add support for new official Lightstreamer client lib HOT 2
- timeInForce for create_open_position() and close_open_position() HOT 4
- fetch_historical_prices_by_epic_and_date_range raise KeyError(key) from err KeyError: 'last' HOT 10
- Sample stream not working HOT 11
- Invalid session token, triggering refresh...
- Workaround for IG `/confirms` bug
- Deprecation error on lightreamer.Subscription HOT 2
- add functions for "Indicative costs and charges"
- Exception: error.security.account-token-invalid HOT 7
- pandas 2.2.0 causes warnings for future deprecations HOT 5
- Future warning in trading_ig\rest.py HOT 5
- IG Login (OAuth) v3 does not require an accountId HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trading-ig.