Using Enums in place of some String values about torrent-name-parser HOT 3 CLOSED

Haha I haven't had a chance to clean this up and make it PR ready yet but if there's interest I will prioritize :)

from torrent-name-parser.

Haha I haven't had a chance to clean this up and make it PR ready yet but if there's interest I will prioritize :)

I am not sure if this would interest you. but you might be able to simplify this code block at the regex matching level

impl FromStr for Codec {
	type Err = Error;
	fn from_str(input: &str) -> Result<Self, Self::Err> {
		match input {
			"X264"|"x264"|"H264"|"h264"|"H.264"|"h.264" => Ok(Self::X264),
			"X265"|"x265"|"H265"|"h265"|"H.265"|"h.265" => Ok(Self::X265),
			"HEVC"|"HEVc"|"HEvC"|"HEvc"|"HeVC"|"HeVc"|"HevC"|"Hevc" => Ok(Self::X265),
			"hEVC"|"hEVc"|"hEvC"|"hEvc"|"heVC"|"heVc"|"hevC"|"hevc" => Ok(Self::X265),
			"XVID"|"XVId"|"XViD"|"XVid"|"XvID"|"XvId"|"XviD"|"Xvid" => Ok(Self::Xvid),
			"xVID"|"xVId"|"xViD"|"xVid"|"xvID"|"xvId"|"xviD"|"xvid" => Ok(Self::Xvid),
			s => Err(Error::InvalidCodec(s.into()))
		}
	}

replace the codec regex with

pub static ref CODEC: Pattern = 
        r"(?i)(?:(?P<x264>[xh][.]?264)|(?P<x265>[xh]\.?265)|(?P<hevc>hevc)|(?P<xvid>xvid))";

This regex matches all 44 string patterns you are using. Though looking at the code you would need to a function that returned a Enum::Codec instead of a str.... and bases that on a .name("x254").or.... So might not be so useful.

Here is the link to a tool I used to test the regex link

from torrent-name-parser.

Haha I haven't had a chance to clean this up and make it PR ready yet but if there's interest I will prioritize :)

I am not sure if this would interest you. but you might be able to simplify this code block at the regex matching level

Another option might be the regex set which allows you to test which pattern matched.
See here

let set = RegexSet::new(&[
    r"[xh]\.264",
    r"[xh]\.265",
    ...
    ...,
]).unwrap();

// You can also test whether a particular regex matched:
let matches = set.matches("foobar");
assert!(!matches.matched(5));
assert!(matches.matched(6));

from torrent-name-parser.